Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing branch from documentAttributes in Container.snapshotBase #8840

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

chensixx
Copy link
Contributor

@chensixx chensixx commented Jan 22, 2022

part of removing container.id #2903
this also involves updating snapshot content so having a separate pr

@github-actions github-actions bot added area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc labels Jan 22, 2022
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jan 22, 2022

@fluid-example/bundle-size-tests: -15 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 379.61 KB 379.61 KB No change
containerRuntime.js 178.85 KB 178.85 KB No change
loader.js 160.46 KB 160.45 KB -15 Bytes
map.js 50.98 KB 50.98 KB No change
matrix.js 145.5 KB 145.5 KB No change
odspDriver.js 192.72 KB 192.72 KB No change
odspPrefetchSnapshot.js 45.08 KB 45.08 KB No change
sharedString.js 166.54 KB 166.54 KB No change
Total Size 1.32 MB 1.32 MB -15 Bytes

Baseline commit: 7665d40

Generated by 🚫 dangerJS against d65038a

@github-actions github-actions bot requested a review from vladsud January 24, 2022 20:08
@github-actions github-actions bot removed the area: tests Tests to add, test infrastructure improvements, etc label Jan 24, 2022
@github-actions github-actions bot added the area: tests Tests to add, test infrastructure improvements, etc label Jan 24, 2022
@chensixx chensixx merged commit e31df83 into microsoft:main Jan 24, 2022
@chensixx chensixx linked an issue Jan 25, 2022 that may be closed by this pull request
@chensixx chensixx deleted the removeBranch branch April 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ComponentContext.documentId, Container.id
3 participants