Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io-parser version used by Fluid Framework has a security vulnerability #4776

Closed
christiango opened this issue Jan 11, 2021 · 4 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file resolution: not an issue
Milestone

Comments

@christiango
Copy link
Member

We're getting an alert in a downstream repo that the socket.io-parser version being used by Fluid Framework (3.3.1 via socke.io-client). The recommendation is to get on socket.io-parser 3.4.1 or later.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-36049

@christiango christiango added the bug Something isn't working label Jan 11, 2021
@ghost ghost added the triage label Jan 11, 2021
@curtisman curtisman added the dependencies Pull requests that update a dependency file label Jan 11, 2021
@curtisman curtisman self-assigned this Jan 11, 2021
@curtisman curtisman removed the triage label Jan 11, 2021
@ghost ghost added the triage label Jan 11, 2021
@curtisman curtisman added this to the January 2021 milestone Jan 11, 2021
@ghost ghost removed the triage label Jan 11, 2021
@curtisman
Copy link
Member

curtisman commented Jan 12, 2021

The fix is back ported to socket.io-parser 3.3.2: https://github.com/socketio/socket.io-parser/releases/tag/3.3.2
And the dependency from socket.io-client is ~3.3.0. So an update to your lock file should suffice.

@christiango
Copy link
Member Author

The component governance tool does not seem to recognize the 3.3.2 as a resolution, so this will probably keep showing up in people's component governance until someone updates the mitigations to include 3.3.2. Not sure how these vulnerabilities get updated

It would probably also be great if we could depend on a version of socket.io-client that has the fix as the minimum version aka ~3.3.2 rather than ~3.3.0 to make sure no one can install the vulnerable version, but it doesn't seem socket.io has released a version of socket.io-client like this

@curtisman
Copy link
Member

Looking at this closed PR, I don't think they are planning to update socket.io-client:

curtisman added a commit that referenced this issue Jan 13, 2021
See #4776

We still have a dependency to 3.1.2 from socket.io-emitter, which don't have an update yet.
@ghost
Copy link

ghost commented Jan 14, 2021

This issue has been marked as being beyond the support scope of Fluid Frameworks's issue board. It will now be closed automatically for house-keeping purposes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file resolution: not an issue
Projects
None yet
Development

No branches or pull requests

2 participants