Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove batchmanager and default FlushMode related feature gates #7365

Closed
andre4i opened this issue Sep 3, 2021 · 1 comment · Fixed by #8833
Closed

Remove batchmanager and default FlushMode related feature gates #7365

andre4i opened this issue Sep 3, 2021 · 1 comment · Fixed by #8833
Assignees
@andre4i
Milestone
March 2022

Comments

@andre4i
Copy link
Contributor

andre4i commented Sep 3, 2021

The following 2 PRs:

are shipping 2 related features behind a feature gate.

We need to ensure that enabling the feature gate does not break existing clients, provide guidance about how to use the APIs to go around any issues and to ultimately remove the feature-gate and the old code. This issue tracks that work.

Acceptance criteria:

  • figure out what/where breaks by enabling the feature gate
  • fix/follow-up fixes for eventual issues found
  • remove feature gate and unused code (such as the BatchManger)
@ghost ghost added the triage label Sep 3, 2021
@andre4i andre4i self-assigned this Sep 3, 2021
@andre4i andre4i mentioned this issue Sep 22, 2021
Closed
@andre4i andre4i mentioned this issue Sep 30, 2021
Merged
@andre4i andre4i added this to the October 2021 milestone Sep 30, 2021
@ghost ghost removed the triage label Sep 30, 2021
@andre4i andre4i mentioned this issue Oct 14, 2021
Closed
andre4i added a commit that referenced this issue Oct 14, 2021
@andre4i
DeltaManager must not throw at disconnect when it still has messages …
92a8440 
…in the buffer (#7645)

While doing some testing in the Bohemia repo to enable removing the batch manager and setting the default flush mode in the runtime to TurnBased (see #7365) I ran into a situation in which the DeltaManager gets disconnected with messages in its buffer. This leads to an error being thrown which ends with the container closing. However, if the container just reconnects, the pending messages are being re-sent.
@andre4i andre4i mentioned this issue Oct 18, 2021
Closed
@andre4i andre4i modified the milestones: October 2021, November 2021 Oct 21, 2021
@andre4i andre4i mentioned this issue Nov 1, 2021
Closed
7 tasks
@andre4i
Copy link
Contributor Author

andre4i commented Dec 27, 2021 •
edited
Loading

The config management feature will be merged soon (#8497). It then needs to be wired in Bohemia first, then we can properly enable this and roll it out.

@andre4i andre4i modified the milestones: December 2021, January 2022 Dec 27, 2021
@andre4i andre4i mentioned this issue Jan 20, 2022
Merged
andre4i added a commit that referenced this issue Jan 21, 2022
@andre4i
Throw possible errors from orderSequentially and close the containe…
86bd8f0 
…r even when the runtime does not own flushing (#8815)

Affects #7365 and #8437
@andre4i andre4i mentioned this issue Jan 21, 2022
Merged
@andre4i andre4i mentioned this issue Feb 17, 2022
Merged
@andre4i andre4i modified the milestones: February 2022, March 2022 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andre4i andre4i

Labels
None yet
Projects
None yet
Milestone
March 2022
Development

Successfully merging a pull request may close this issue.

Remove feature gates for flushmode and batchmanager andre4i/FluidFramework
2 participants
@anthony-murphy @andre4i