Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerRuntime.orderSequentially() and exceptions from callback #8437

Closed
vladsud opened this issue Dec 1, 2021 · 0 comments · Fixed by #8579
Closed

ContainerRuntime.orderSequentially() and exceptions from callback #8437

vladsud opened this issue Dec 1, 2021 · 0 comments · Fixed by #8579
Assignees
Labels
area: runtime Runtime related issues bug Something isn't working
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Dec 1, 2021

Today, if exception is thrown from callback, we flush partial batch and continue.
This does not have clear semantics on what happens next (i.e. whoever runs such batch may close container, but likely he/she will not).
Even if container is closed, we still push partial batch out.
I think this is wrong and we should close container, similar how we do with any exception during op processing (DataCorruptionError, CreateProcessingError usages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants