Whiteboard undo redo bug #11260
Merged
Whiteboard undo redo bug #11260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
taylorsw04
requested changes
Jul 25, 2022
noencke
reviewed
Jul 27, 2022
jenn-le
reviewed
Jul 27, 2022
jenn-le
reviewed
Jul 27, 2022
noencke
reviewed
Jul 28, 2022
noencke
reviewed
Jul 28, 2022
noencke
reviewed
Jul 28, 2022
noencke
reviewed
Jul 29, 2022
noencke
reviewed
Jul 29, 2022
noencke
approved these changes
Jul 29, 2022
noencke
reviewed
Aug 4, 2022
noencke
approved these changes
Aug 4, 2022
jenn-le
approved these changes
Aug 4, 2022
taylorsw04
approved these changes
Aug 4, 2022
|
This commit is queued for merging with the |
seanimam
pushed a commit
to seanimam/FluidFramework
that referenced
this pull request
Aug 9, 2022
* Return undefined during empty detach trait * return undefined when inserting empty traits * Fix previous commit for inserting empty trait * update test case * fix lint errors * fix lint error * revert previous commit * fix logic for inserting empty trait * Add test case for empty detach * fix lint errors * Updated test titles, changed test case logic. * Changed test case formatting * fix linting error * Updated traitlabel, and fixed testcase * prevent residual builtNodes after insert * replace undefined with continue for empty traits * build but skips insert/detach of empty traits * update test cases for skip instead of undefined * Simplified test case * Add use of helper function * Added expectDefined to test case * test to check if built/detached nodes are cleared * Add test case for single empty insert * fix lint errors * added whitespace * added logging to revert function * Comment addressing input/output array size * cleaned up code for checking if logger is defined
daesun-park
added a commit
to daesun-park/FluidFramework
that referenced
this pull request
Nov 11, 2022
* Return undefined during empty detach trait * return undefined when inserting empty traits * Fix previous commit for inserting empty trait * update test case * fix lint errors * fix lint error * revert previous commit * fix logic for inserting empty trait * Add test case for empty detach * fix lint errors * Updated test titles, changed test case logic. * Changed test case formatting * fix linting error * Updated traitlabel, and fixed testcase * prevent residual builtNodes after insert * replace undefined with continue for empty traits * build but skips insert/detach of empty traits * update test cases for skip instead of undefined * Simplified test case * Add use of helper function * Added expectDefined to test case * test to check if built/detached nodes are cleared * Add test case for single empty insert * fix lint errors * added whitespace * added logging to revert function * Comment addressing input/output array size * cleaned up code for checking if logger is defined
jenn-le
pushed a commit
that referenced
this pull request
Nov 11, 2022
Cherry pick of PR #11260 from main to release branch.
tylerbutler
added a commit
to tylerbutler/FluidFramework
that referenced
this pull request
Mar 26, 2024
tylerbutler
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an undo/redo of an empty trait is done, it can lead to a insert/detach of a malformed trait. This issue occurs when the following is done.
This PR aims to prevent this issue by skipping the change rather than performing an insertion/detachment of an empty trait. The undo/redo logic of the revert( ) method in HistoryEditFactory.ts is updated to achieve this. Additionally, an optional telemetry logger is passed through the function to track these events when they occur. More details regarding this issue can be found in Bug 635