Code

Whiteboard undo redo bug#11260

Code

Merged

daesun-park merged 28 commits intomicrosoft:mainmicrosoft/FluidFramework:mainfrom daesun-park:whiteboard-undo-redo-bugdaesun-park/FluidFramework:whiteboard-undo-redo-bugCopy head branch name to clipboardAug 4, 2022

+106-13

Commits

Commits on Jul 23, 2022

• Return undefined during empty detach trait

  daesun-park

  committed
  25f42a2

  Copy full SHA for 25f42a2

• return undefined when inserting empty traits

  daesun-park

  committed
  8b1d7f4

  Copy full SHA for 8b1d7f4

• Fix previous commit for inserting empty trait

  daesun-park

  committed
  de54a91

  Copy full SHA for de54a91

• update test case

  daesun-park

  committed
  d4f9f97

  Copy full SHA for d4f9f97

• fix lint errors

  daesun-park

  committed
  7e7634c

  Copy full SHA for 7e7634c

• fix lint error

  daesun-park

  committed
  a23d884

  Copy full SHA for a23d884

• revert previous commit

  daesun-park

  committed
  1b9c8be

  Copy full SHA for 1b9c8be

• fix logic for inserting empty trait

  daesun-park

  committed
  f4d93ae

  Copy full SHA for f4d93ae

Commits on Jul 25, 2022

• Add test case for empty detach

  daesun-park

  committed
  0229c91

  Copy full SHA for 0229c91

• fix lint errors

  daesun-park

  committed
  4b150f0

  Copy full SHA for 4b150f0

Commits on Jul 26, 2022

• Updated test titles, changed test case logic.

  daesun-park

  committed
  cace0fc

  Copy full SHA for cace0fc

• Changed test case formatting

  daesun-park

  committed
  7744c84

  Copy full SHA for 7744c84

• fix linting error

  daesun-park

  committed
  c217b8d

  Copy full SHA for c217b8d

• Updated traitlabel, and fixed testcase

  daesun-park

  committed
  75cbb54

  Copy full SHA for 75cbb54

Commits on Jul 27, 2022

• prevent residual builtNodes after insert

  daesun-park

  committed
  28c1ab0

  Copy full SHA for 28c1ab0

• replace undefined with continue for empty traits

  daesun-park

  committed
  695aab5

  Copy full SHA for 695aab5

Commits on Jul 28, 2022

• build but skips insert/detach of empty traits

  daesun-park

  committed
  22d7e83

  Copy full SHA for 22d7e83

• update test cases for skip instead of undefined

  daesun-park

  committed
  eb28397

  Copy full SHA for eb28397

Commits on Jul 29, 2022

• Simplified test case

  daesun-park

  committed
  a2372e8

  Copy full SHA for a2372e8

• Add use of helper function

  daesun-park

  committed
  d663be6

  Copy full SHA for d663be6

• Added expectDefined to test case

  daesun-park

  committed
  fac9ddd

  Copy full SHA for fac9ddd

• test to check if built/detached nodes are cleared

  daesun-park

  committed
  971e240

  Copy full SHA for 971e240

• Add test case for single empty insert

  daesun-park

  committed
  43a8193

  Copy full SHA for 43a8193

• fix lint errors

  daesun-park

  committed
  514eccc

  Copy full SHA for 514eccc

• added whitespace

  daesun-park

  committed
  75beef8

  Copy full SHA for 75beef8

Commits on Aug 4, 2022

• added logging to revert function

  daesun-park

  committed
  e8cc4a2

  Copy full SHA for e8cc4a2

• Comment addressing input/output array size

  daesun-park

  committed
  3cc059f

  Copy full SHA for 3cc059f

• cleaned up code for checking if logger is defined

  daesun-park

  committed
  b36d768

  Copy full SHA for b36d768