Expose data/helpers to check for no changes in bundle sizes to reduce noise #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinwt
reviewed
Oct 29, 2020
| * @param comparisons | ||
| */ | ||
| export function bundlesContainNoChanges(comparisons: BundleComparison[]): boolean { | ||
| for (let i = 0; i < comparisons.length; i++) { |
There was a problem hiding this comment.
non-functional
Thoughts?
for (const { commonBundleMetrics } of comparisons) {
And below:
const metrics = Object.values(commonBundleMetrics); // values ignores keys
for (const { baseline, compare } of metrics) {
Or an unreadable(?) one-liner:
comparisons.every(({ commonBundleMetrics }) => Object.values(commonBundleMetrics)
.every(({ baseline, compare }) => baseline.parsedSize === compare.parsedSize));There was a problem hiding this comment.
i like the unreadable one but the other one is good too
arinwt
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #4124
Return the raw data from the bundle comparison in addition to the formatted output, and add a helper to check if that raw data represents no size changes.
Next steps are to publish the new version of this package, and update build-tools to make this check before posting a size comment.