Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce bundle size analysis noise #4124

Closed
heliocliu opened this issue Oct 27, 2020 · 0 comments · Fixed by #4203
Closed

Reduce bundle size analysis noise #4124

heliocliu opened this issue Oct 27, 2020 · 0 comments · Fixed by #4203
Assignees
@heliocliu
Labels
area: dev experience Improving the experience of devs building on top of fluid
Milestone
November 2020

Comments

@heliocliu
Copy link
Contributor

People who participate in lots of PRs in our repo (or are automatically assigned to lots of PRs...) feel that the volume of emails from the bundle size comments is too large. Looking at the most recent PRs, roughly 2/3 which generate size comments do not show any size change. In these cases we can eschew posting a comment. To prevent potential confusion with outdated comments though (e.g. an error comment gets posted and the next commit succeeds with no size change, or a size change comment is posted and the next commit has no size change), we should only skip when we didn't already make a comment.
@heliocliu heliocliu added the area: dev experience Improving the experience of devs building on top of fluid label Oct 27, 2020
@heliocliu heliocliu added this to the November 2020 milestone Oct 27, 2020
@heliocliu heliocliu self-assigned this Oct 27, 2020
@heliocliu heliocliu mentioned this issue Oct 29, 2020
Merged
heliocliu added a commit that referenced this issue Oct 29, 2020
@heliocliu
Expose data/helpers to check for no changes in bundle sizes to reduce…
cee4f27 
… noise (#4153)

First part of #4124

Return the raw data from the bundle comparison in addition to the formatted output, and add a helper to check if that raw data represents no size changes.

Next steps are to publish the new version of this package, and update build-tools to make this check before posting a size comment.
@heliocliu heliocliu mentioned this issue Oct 30, 2020
Merged
heliocliu added a commit that referenced this issue Oct 30, 2020
@heliocliu
use new bundle-size-tools (#4179)
e0b45ff 
Part 2 of #4124

Consume the new version of bundle-size-tools in build-tools to only post a comment when a size change is detected. In cases where the size does not change, we do not post a comment and danger will delete any old comments. The implication for users is then that if there is no comment, the bundle size is not affected by the pr
@heliocliu heliocliu mentioned this issue Oct 30, 2020
Merged
heliocliu added a commit that referenced this issue Nov 2, 2020
@heliocliu
update build-tools version (#4203)
7bc31cc 
This pulls in the changes to the bundle size analysis comments, and changes that don't affect the bundle size will no longer receive notifications.

Fixes #4124
This was referenced Aug 18, 2022
Open
Open
This was referenced Aug 18, 2022
Open
Open
Open
This was referenced Aug 18, 2022
Open
Open
Open
Open
Open
Open
Open
Open
@MarcelRaschke MarcelRaschke mentioned this issue Aug 18, 2022
Open
@snyk-bot snyk-bot mentioned this issue Aug 18, 2022
Open
This was referenced Aug 18, 2022
Open
Merged
This was referenced Aug 18, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Aug 19, 2022
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 19, 2022
Open
Open
@MarcelRaschke MarcelRaschke mentioned this issue Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this issue Aug 19, 2022
Open
This was referenced Aug 19, 2022
Open
Open
Open
Open
Open
This was referenced Aug 19, 2022
Open
Open
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 20, 2022
Open
Open
Open
Open
This was referenced Aug 20, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heliocliu heliocliu

Labels
area: dev experience Improving the experience of devs building on top of fluid
Projects
None yet
Milestone
November 2020
Development

Successfully merging a pull request may close this issue.

Update build-tools version in client heliocliu/FluidFramework-1
1 participant
@heliocliu