Consume new bundle-size-tools pkg in build-tools to reduce alert noise #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christiango this updates build-tools and i'll need to run a release after to consume in the client repo. if any of your upcoming changes around this area touch build-tools as well, let me know and i can wait for you to run the release |
|
Thanks for the heads up, nope I don't need anymore upstream changes. Just the client bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #4124
Consume the new version of bundle-size-tools in build-tools to only post a comment when a size change is detected. In cases where the size does not change, we do not post a comment and danger will delete any old comments. The implication for users is then that if there is no comment, the bundle size is not affected by the pr