-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building reusable components: Single dependency passing #4266
Conversation
… causing failure to init child objects
…to Providers # Conflicts: # examples/data-objects/todo/src/Todo/todoInstantiationFactory.ts
…to Providers # Conflicts: # packages/test/test-utils/package.json # packages/test/version-test-1/package.json
I haven't spent any time on this, but as a general note, i think aqueduct is getting pretty bloated and complex. i don't know if this is the right place/time, but we should consider pushing down concepts/patterns that make sesnse to the runtime layer, as ideally aqueduct is a light wrapper putting things together. |
@anthony-murphy , thanks for feedback! If possible, I'd prefer to move here incrementally, as even these changes are rather massive (unfortunately), even though I've implemented only small part of what needs to be done here (i.e. it's mostly plumbing work). I'm reusing existing (but not used) functionality backed into DataObject, and for most part do not add that much new functionality. I'd prefer to keep going that route, and once it takes its reasonable shape (after all the "next steps" I mentioned above), it would be great time to re0evaluate. What do you think? Note that some things will become simpler for DataObject. For example, I think I'll combine optional & required templated args on DataObject, |
I've raised 3 staging PRs from here. Once they settle, I'll raise final PR with actual changes. |
This is draft PR, the purpose of it to demonstrate first steps on implementation of issue #4265 - Support building reusable components / eco-system, get overall feedback on design direction.
It will be broken into smaller PRs that can be easier reviewed.
There is a lot of glue code and many changes are simply massaging existing code to get it better shape to support functionality.
Here are the main things to pay attention:
Next steps: