-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerRuntimeFactoryWithDefaultDataStore takes factory, not symbolic name #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
skylerjokiel,
ChumpChief,
arinwt and
curtisman
November 9, 2020 05:05
■ @fluidframework/base-host: No change
⯆ @fluid-example/bundle-size-tests: -104 Bytes
Baseline commit: 80cb16e |
heliocliu
reviewed
Nov 10, 2020
heliocliu
reviewed
Nov 10, 2020
heliocliu
reviewed
Nov 10, 2020
heliocliu
reviewed
Nov 10, 2020
heliocliu
approved these changes
Nov 10, 2020
heliocliu
reviewed
Nov 10, 2020
...work/aqueduct/src/container-runtime-factories/containerRuntimeFactoryWithDefaultDataStore.ts
Show resolved
Hide resolved
Co-authored-by: Helio Liu <59622401+heliocliu@users.noreply.github.com>
heliocliu
approved these changes
Nov 10, 2020
This reverts commit 2646044.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting smaller changes from #4266
This change is required for future changes, in order to create root data store through Aqueduct's data factory, thus using direct (and detached) creation process of data store, with ability to pass local scope to an object.
Also adding wrappers to create data stores - from async getters, or ability to rename it.
Also removing most of cases where we get data store name from package.json - this is not a good example to follow due to perf considerations (increases package size with all of package.json), as well as backward compatibility considerations (factory names can't change, and changing package name or moving code between packages would cause such change; this also does not compose well, as it assumes single factory per package).