Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerRuntimeFactoryWithDefaultDataStore takes factory, not symbolic name #4275

Merged
merged 9 commits into from
Nov 10, 2020

Conversation

vladsud
Copy link
Contributor

@vladsud vladsud commented Nov 9, 2020

Extracting smaller changes from #4266

This change is required for future changes, in order to create root data store through Aqueduct's data factory, thus using direct (and detached) creation process of data store, with ability to pass local scope to an object.

Also adding wrappers to create data stores - from async getters, or ability to rename it.

Also removing most of cases where we get data store name from package.json - this is not a good example to follow due to perf considerations (increases package size with all of package.json), as well as backward compatibility considerations (factory names can't change, and changing package name or moving code between packages would cause such change; this also does not compose well, as it assumes single factory per package).

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 9, 2020

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 163.82 KB 163.82 KB No change
Total Size 163.82 KB 163.82 KB No change
@fluid-example/bundle-size-tests: -104 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 181.56 KB 181.46 KB -104 Bytes
map.js 39.78 KB 39.78 KB No change
matrix.js 137.43 KB 137.43 KB No change
odspDriver.js 194.03 KB 194.03 KB No change
sharedString.js 151.05 KB 151.05 KB No change
Total Size 703.85 KB 703.75 KB -104 Bytes

Baseline commit: 80cb16e

Generated by 🚫 dangerJS against 8760813

vladsud and others added 2 commits November 9, 2020 21:11
Co-authored-by: Helio Liu <59622401+heliocliu@users.noreply.github.com>
@github-actions github-actions bot requested a review from markfields November 10, 2020 18:02
@vladsud vladsud merged commit c97c692 into microsoft:main Nov 10, 2020
@vladsud vladsud deleted the Prividers_Factory branch November 10, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants