summarizeAsync #8592
Merged
summarizeAsync #8592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
scarlettjlee
commented
Dec 20, 2021
vladsud
reviewed
Dec 20, 2021
vladsud
reviewed
Dec 20, 2021
| extends EventEmitterWithErrorHandling<TEvent> implements ISharedObject<TEvent> { | ||
| /** | ||
| * @param obj - The thing to check if it is a SharedObject | ||
| * @returns Returns true if the thing is a SharedObject | ||
| */ | ||
| public static is(obj: any): obj is SharedObject { | ||
| public static is(obj: any): obj is SharedObjectCore { |
There was a problem hiding this comment.
It's not directly related to your changes, but I believe this is wrong - opened #8594 to track it
vladsud
reviewed
Dec 20, 2021
vladsud
reviewed
Dec 20, 2021
vladsud
reviewed
Dec 21, 2021
vladsud
reviewed
Dec 21, 2021
vladsud
approved these changes
Dec 21, 2021
github-actions
bot
added
area: dds: propertydds
area: dds: sharedstring
area: tests
This was
linked to
issues
Jan 3, 2022
⯆ @fluid-example/bundle-size-tests: -1.79 KB
Baseline commit: f60b531 |
scarlettjlee
commented
Jan 3, 2022
github-actions
bot
added
the
breaking change
DLehenbauer
reviewed
Jan 3, 2022
packages/dds/cell/src/cell.ts
Outdated
| const blobContent = serializer.stringify(content, this.handle); | ||
| const builder = new SummaryTreeBuilder(); | ||
| builder.addBlob(snapshotFileName, blobContent); | ||
| return builder.getSummaryTree(); |
There was a problem hiding this comment.
The cleanup to use SummaryTreeBuilder() everywhere is very nice, thank you.
DLehenbauer
approved these changes
Jan 3, 2022
vladsud
reviewed
Jan 4, 2022
vladsud
reviewed
Jan 4, 2022
vladsud
reviewed
Jan 4, 2022
vladsud
reviewed
Jan 4, 2022
github-actions
bot
requested review from
vladsud and
DLehenbauer
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for parts 1 and 2 of Vlad's comment here on prior abandoned PR.
Add a new method on IChannel (initially optional for compat) to do summarization asynchronously and only call this during regular summarization, not attach.
SharedObject is split into SharedObjectCore and SharedObject, where Core does not have implementations for summarize or GC. DDS implementers are free to implement as they like. For existing DDSs in this repo, summarizeAsync will call into summarizeCore (previously snapshotCore) as synchronous summarize does.