-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove convertToSummaryTreeWithStats from DDSs #8737
Remove convertToSummaryTreeWithStats from DDSs #8737
Conversation
⯆ @fluid-example/bundle-size-tests: -2.26 KB
Baseline commit: 90b900a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. So happy to see this getting cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easy to make mistake here and not notice.
Can you please validate that each case you touched
- has UT covering summarization
- OR covered in snapshot tests (i.e. there is file that touches that DDS)
- OR we validated summarization manually (by running some sample that uses it).
Change remaining summarizeCore implementations to directly create ISummaryTreeWithStats instead of creating ITree and then converting. This completes the work started in #8592 which changed the return type from ITree to ISummaryTreeWithStats.
There are uses of conversion functions in container runtime (will be fixed with #8286), summarizer node, and data stores so I can't remove them yet.
I'll remove the fullTree parameter in summarizeCore in a separate PR to keep this change cleaner.
Closes #8652