Various updates #306
Merged
Various updates #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skottmckay
commented
Nov 14, 2025
skottmckay
commented
- use consistent app name so all downloaded models go to the same location
- add some utilities
- ensure EPs are downloaded to make it clear that that is what takes time on the first run
- add more space in the code to separate sections
- reorder some things to try and make the output a bit more intuitive if you haven't read the code yet
- add RC package names
- target net9* everywhere
- the SDK targets net8 as a lower common denominator. app can target anything later than that
- try and clarify the model/model variant options in HelloFoundryLocalSdk
- keep other apps simple and alias based
- use consistent app name so all downloaded models go to the same location - add some utilities - ensure EPs are downloaded to make it clear that that is what takes time on the first run - add more space in the code to separate sections - reorder some things to try and make the output a bit more intuitive if you haven't read the code yet - target net9* everywhere - the SDK targets net8 as a lower common denominator. app can target anything later than that - try and clarify the model/model variant options in HelloFoundryLocalSdk - keep other apps simple and alias based
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the C# Getting Started samples to use .NET 9.0, introduces shared utilities for consistent behavior across samples, and improves code organization and clarity. The changes ensure all samples use a consistent app name for model downloads and provide better user feedback during execution provider downloads.
- Updated all sample projects to target .NET 9.0
- Introduced shared utility code including logger factory and spinner for long-running operations
- Standardized app naming to "foundry_local_samples" across all examples
- Enhanced HelloFoundryLocalSdk with detailed documentation on model variant selection
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/cs/GettingStarted/windows/HelloFoundryLocalSdk/HelloFoundryLocalSdk.csproj | Updated to target .NET 9.0 and include shared utilities |
| samples/cs/GettingStarted/windows/FoundryLocalWebServer/FoundryLocalWebServer.csproj | Updated to target .NET 9.0 and include shared utilities with wildcard pattern |
| samples/cs/GettingStarted/windows/AudioTranscriptionExample/AudioTranscriptionExample.csproj | Updated to target .NET 9.0 and include shared utilities with wildcard pattern |
| samples/cs/GettingStarted/src/Shared/Utils.cs | New file providing shared logger factory and spinner utility for samples |
| samples/cs/GettingStarted/src/HelloFoundryLocalSdk/Program.cs | Added EP download spinner, improved model variant documentation, and standardized app name |
| samples/cs/GettingStarted/src/FoundryLocalWebServer/Program.cs | Added EP download spinner, refactored logger creation, and standardized app name |
| samples/cs/GettingStarted/src/AudioTranscriptionExample/Program.cs | Added EP download spinner, simplified cancellation token usage, and standardized app name |
| samples/cs/GettingStarted/nuget.config | Updated local feed path to generic placeholder |
| samples/cs/GettingStarted/cross-platform/HelloFoundryLocalSdk/HelloFoundryLocalSdk.csproj | Updated to include shared utilities with wildcard pattern |
| samples/cs/GettingStarted/cross-platform/FoundryLocalWebServer/FoundryLocalWebServer.csproj | Updated to include shared utilities with wildcard pattern |
| samples/cs/GettingStarted/cross-platform/AudioTranscriptionExample/AudioTranscriptionExample.csproj | Updated to include shared utilities with wildcard pattern |
| samples/cs/GettingStarted/Directory.Packages.props | Updated package versions to RC versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
samuel100
approved these changes
Nov 14, 2025
samuel100
added a commit
that referenced
this pull request
Nov 18, 2025
* sdkv2 initial * added pointer to MS Learn * refactor api reference * update to latest builds * Various updates (#306) * Various updates - use consistent app name so all downloaded models go to the same location - add some utilities - ensure EPs are downloaded to make it clear that that is what takes time on the first run - add more space in the code to separate sections - reorder some things to try and make the output a bit more intuitive if you haven't read the code yet - target net9* everywhere - the SDK targets net8 as a lower common denominator. app can target anything later than that - try and clarify the model/model variant options in HelloFoundryLocalSdk - keep other apps simple and alias based * Update comments * Update samples/cs/GettingStarted/src/FoundryLocalWebServer/Program.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix LoggerFactory lifetime --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * api doc update * api doc update * simplify readme * tidy * add model management example * fix title * update nuget.config * update whisper to select cpu variant * update configs and props * update to latest * made the ORT linux dependencies conditional * update winml csproj * updated nuget.config for ORT feed --------- Co-authored-by: Scott McKay <Scott.McKay@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.