-
Notifications
You must be signed in to change notification settings - Fork 225
C# SDK Refresh #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# SDK Refresh #307
Conversation
* Various updates - use consistent app name so all downloaded models go to the same location - add some utilities - ensure EPs are downloaded to make it clear that that is what takes time on the first run - add more space in the code to separate sections - reorder some things to try and make the output a bit more intuitive if you haven't read the code yet - target net9* everywhere - the SDK targets net8 as a lower common denominator. app can target anything later than that - try and clarify the model/model variant options in HelloFoundryLocalSdk - keep other apps simple and alias based * Update comments * Update samples/cs/GettingStarted/src/FoundryLocalWebServer/Program.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix LoggerFactory lifetime --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ndry-Local into samuel100/sdkvnext
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…o samuel100/sdkvnext
| <ItemGroup Condition="'$(RuntimeIdentifier)' == 'linux-x64'"> | ||
| <PackageReference Include="Microsoft.ML.OnnxRuntime.Gpu" /> | ||
| <PackageReference Include="Microsoft.ML.OnnxRuntimeGenAI.Cuda" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be covered by the last part of ExcludeExtraLibs.props. Can cleanup later though.
Causes this warning as a) Core add the GenAI.Cuda as a dependencies, then b) we add it in the props file to be explicit about the version as we use that in the path to copy. A third addition here really shouldn't be necessary.
/home/s/github/fl.sdk/samples/cs/GettingStarted/cross-platform/FoundryLocalWebServer/FoundryLocalWebServer.csproj : warning NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.ML.OnnxRuntimeGenAI.Cuda , Microsoft.ML.OnnxRuntimeGenAI.Cuda 0.11.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this at some point given it's now copying .so file on linux?
Refresh of C# SDK