-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Rewrite R demos, replace with vignettes #1944
Comments
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
I want to add (for whoever comes back to this issue), that we should consider factoring |
I think that when we come to this, we should change from the current |
I just updated the title of this issue per this comment: #1944 (comment) |
@jameslamb Are there still plans to replace demos by simple vignettes? If yes, I could give it a try. |
Yes definitely! I have been focused on the new Dask module in the Python package recently, so haven't been giving as much attention to the R side. I'd love if you submitted a proposal for this. I don't think you should try to move all demos at once. I think it would be good to have a first pull request that just adds an introductory "Getting Started with LightGBM" vignette, to replace https://github.com/microsoft/LightGBM/blob/master/R-package/demo/basic_walkthrough.R. Thank you so much for offering to help 😀 |
Sure thing! |
Adding some relevant links I've found while investigating #3946: |
Pulling this discussion over from #4775 (comment), I'd like to propose the following list of vignettes to start (with the names of relevant demos from https://github.com/microsoft/LightGBM/tree/f7e39388d0327e687854f22d7e06aec302770994/R-package/demo in parentheses) @mayer79 what do you think about this list? Any topics you think are missing?
Also linking #4859. I think I think we should try to avoid documenting too much information that overlaps with other docs in the project. For example, the R-package README (https://lightgbm.readthedocs.io/en/latest/R/index.html) already has significant details about different installation methods, so vignettes don't need to cover that. Also linking this important discussion with @StrikerRUS about being cautious about vignette code that takes too long to run: |
The R package should have all the demos remade, short, concise, and focusing on specific topics, instead of currently being confusing to end-users who are trying to pick up the library (see some the recent issues, especially the multiclass ones).
I'll rewrite most of them later in the next months.
The text was updated successfully, but these errors were encountered: