[R-package] removed unnecessary Suggests dependencies #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
force-pushed
the
misc/r_suggests
branch
from
43c8a31
to
d5dab71
Compare
Laurae2
approved these changes
Nov 10, 2019
guolinke
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #2530 that we have some packages listed as
Suggestsdependencies for the R package which do not show up anywhere in the examples, tests, or package code (as far as I can tell). We can remove:Ckmeans.1d.dpDiagrammeRigraphstringivcdI think we should remove these suggested dependencies to reduce the cost of building this library. In some cases R will install Suggests of all packages recursively (e.g. with
devtools::install()). Also when usingR CMD check, you will get an error if anySuggestsdependencies are not found, unless you explicitly express it with an environment variable.