-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] [tests] reduce verbosity in unit tests #4862
Labels
Comments
This was referenced Dec 20, 2021
This was referenced Mar 27, 2022
This was referenced May 7, 2022
This was referenced May 21, 2022
jameslamb
added a commit
that referenced
this issue
May 29, 2022
This was referenced May 29, 2022
jameslamb
added a commit
that referenced
this issue
May 31, 2022
This was referenced Oct 7, 2022
This issue has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Summary
Unit tests in the R package which are not explicitly testing
{lightgbm}
's behavior for different values of the parameterverbose
should useverbose = -1L
to suppress all other log outputs.Motivation
Suppressing more log output in tests may make them faster by reducing the number of times the package has to write to stdout / stderr.
It will also improve the usability of the logs for quickly identifying where issues happened.
Description
This work should be done in multiple small pull requests, not one huge one changing all tests.
It should be possible to override the value of
verbose
should be using an environment variable, so that developers can occasionally, easily run the tests in "debug" mode if additional logs are needed to identify issues.Maybe like this:
References
Created from this comment: #4567 (review)
The text was updated successfully, but these errors were encountered: