-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] reduce verbosity in some unit tests #4879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like this approach, thanks!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #4862.
This PR proposes the first batch of changes to reduce the verbosity of the R package tests. I only changed a few tests, as this PR is mainly focused on getting a review of the proposed approach.
How I Tested This
I used the following code to determine the impact of this change.
On
master
, the R tests generate 3065 lines of logs.As of this PR, that's reduced to 2984.
Why allow changing this with an environment variable?
I think it would be useful to occasionally see all LightGBM logs from tests.
That can help to catch issues like #4225 that don't show up as test errors.