Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] added f-string to python-package/lightgbm/basic.py #4143

Merged
merged 10 commits into from
May 15, 2021
Merged

[python] added f-string to python-package/lightgbm/basic.py #4143

merged 10 commits into from
May 15, 2021

Conversation

NovusEdge
Copy link
Contributor

No description provided.

@NovusEdge
Copy link
Contributor Author

#4136

@jameslamb jameslamb changed the title added f-string to python-package/lightgbm/basic.py [python] added f-string to python-package/lightgbm/basic.py May 11, 2021
@jameslamb
Copy link
Collaborator

I merged in the latest changes from the master branch to this PR tonight, following the steps described in #4144 (review).

I also patched a few small things in b52f56c

@StrikerRUS I think this is now ready for review.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but since I added a few changes I don't think my approval should count towards a merge.

@StrikerRUS
Copy link
Collaborator

Please update

raise ValueError("DataFrame.dtypes for data must be int, float or bool.\n"
"Did not expect the data types in the following fields: "
+ ', '.join(data.columns[bad_indices]))

tree_num = str(tree_index) + '-' if tree_index is not None else ''

return tree_num + node_type + node_num

@jameslamb
Copy link
Collaborator

Please update

updated in a2cfecb and merged in latest master

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just few suggestions.

python-package/lightgbm/basic.py Outdated Show resolved Hide resolved
python-package/lightgbm/basic.py Outdated Show resolved Hide resolved
python-package/lightgbm/basic.py Outdated Show resolved Hide resolved
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants