-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] added f-string to python-package/lightgbm/basic.py #4143
Conversation
I merged in the latest changes from the I also patched a few small things in b52f56c @StrikerRUS I think this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but since I added a few changes I don't think my approval should count towards a merge.
Please update LightGBM/python-package/lightgbm/basic.py Lines 537 to 539 in 8937022
LightGBM/python-package/lightgbm/basic.py Line 2426 in 8937022
LightGBM/python-package/lightgbm/basic.py Line 2431 in 8937022
|
updated in a2cfecb and merged in latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just few suggestions.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
No description provided.