[python] added f-strings to python-package/lightgbm/dask.py

[NovusEdge]

No description provided.

[NovusEdge]

#4136

[jameslamb]

Thanks very much for your continued efforts! Please see the suggestions I left.

To test changes locally, I recommend that you try installing the library:

cd python-package
python setup.py install

And re-building the documentation (since this PR touches some things called __doc__), following the steps at https://github.com/microsoft/LightGBM/blob/master/docs/README.rst#build.

Building locally might help you to iterate faster and to get reviews more quickly.

[jameslamb]

@NovusEdge @StrikerRUS this PR and the others like it (#4142, #4143, #4144) have been open for a few weeks with no updates, so I'd like to update them and move them forward.

I started with this PR. I've used the power that GitHub gives us as maintainers to push to branches on forks that are involved in open pull requests to this repo. I've pushed commits to this PR, but @NovusEdge you'll still get credit as a contributor when this is merged to master.

I used the commands below to update this branch with the latest master.

git clone --recursive git@github.com:NovusEdge/LightGBM.git novus-lgb
cd novus-lgb

git remote add upstream git@github.com:microsoft/LightGBM.git
git pull origin master
git fetch origin dask
git checkout dask
git merge master
git push origin dask

After that, I built the documentation locally to check that the changes are ok. Docs look correct to me!

cd docs
make clean html
open _build/html/index.html

[StrikerRUS]

Need to be updated

LightGBM/python-package/lightgbm/dask.py

Line 70 in 08d1ce4

raise TypeError('Data must be one of: numpy arrays, pandas dataframes, sparse matrices (from scipy). Got %s.' % str(type(seq[0])))

LightGBM/python-package/lightgbm/dask.py

Line 416 in 08d1ce4

'%s:%d' % (urlparse(worker_address).hostname, port)

LightGBM/python-package/lightgbm/dask.py

Line 575 in 08d1ce4

raise TypeError('Data must be either Dask Array or Dask DataFrame. Got %s.' % str(type(data)))

[jameslamb]

Need to be updated

updated in 8f01b98

[StrikerRUS]

Thanks for helping with this!
Here are some more problems I've found when rendered the docs.

[jameslamb]

Thanks very much @NovusEdge ! And as always thank you for the thorough review, @StrikerRUS

[StrikerRUS]

@jameslamb Many thanks for pushing PRs with f-strings forward!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.