-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress categorical warning (fixes #3379) #4762
Conversation
I just added |
oh! Also @hzy46 please check your Notice that your profile picture is not showing up: See my suggestions in #3607 (comment) and uptake/pkgnet#284 (review) for how to fix this. |
_log_warning('Overriding the parameters from Reference Dataset.') | ||
params = self.get_params() | ||
if params != reference_params: | ||
if self._compare_params_for_warning(params, reference_params) is False: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to get_params
, both params
and reference_params
can be None
. In this case they cannot be directly iterated in the _compare_params_for_warning
method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks shiyu. I also found this issue in the CI. Will add a check on this.
93c2e72
to
fe166b1
Compare
Close this to use another PR. |
Thanks @jameslamb . I used a different PR. Now the author info issue should be addressed in #4768 |
Thanks! It looks like you already did But we can review the new PR and keep this, no problem! Just letting you know in case you have this problem in the future. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
To fix #3379