Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress categorical warning (fixes #3379) #4768

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Suppress categorical warning (fixes #3379) #4768

merged 1 commit into from
Nov 8, 2021

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Nov 4, 2021

To fix #3379

@hzy46 hzy46 mentioned this pull request Nov 4, 2021
Closed
@shiyu1994
Copy link
Collaborator

Close and reopen this PR to retrigger ci tests after the fix of #4769.

@shiyu1994 shiyu1994 closed this Nov 5, 2021
@shiyu1994 shiyu1994 reopened this Nov 5, 2021
shiyu1994
shiyu1994 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@shiyu1994 shiyu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approve given that all tests are passed. Thank you!

@StrikerRUS
Copy link
Collaborator

Hmm, I'm very surprised that just closing-reopening made all tests to pass!
The base branch of this PR still lacks our recently merged workaround (#4770) for stuck Dask tests, but CI status is all-green. Strange...

https://github.com/hzy46/LightGBM/blob/suppress_warning_of_categorical_feature/.ci/test.sh#L117

image

cc @jameslamb @jmoralez

@jmoralez
Copy link
Collaborator

jmoralez commented Nov 5, 2021

Seems like the jobs took into account the incorporated restrictions (linux regular, linux sdist, linux bdist). I was surprised as well.

@jameslamb
Copy link
Collaborator

I think it might be related to #4678 (comment)

The code run in CI might not have been "this branch" but "this branch merged with master".

@shiyu1994 shiyu1994 merged commit b1facf5 into microsoft:master Nov 8, 2021
@StrikerRUS StrikerRUS mentioned this pull request Nov 23, 2021
Merged
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
Closed
13 tasks
@StrikerRUS StrikerRUS mentioned this pull request Mar 25, 2022
Merged
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@jameslamb jameslamb mentioned this pull request Feb 1, 2023
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shiyu1994 shiyu1994 shiyu1994 approved these changes

@chivee chivee Awaiting requested review from chivee

@henry0312 henry0312 Awaiting requested review from henry0312

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

@tongwu-sh tongwu-sh Awaiting requested review from tongwu-sh

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python] suppress the warning about categorical feature override
5 participants
@hzy46 @shiyu1994 @StrikerRUS @jmoralez @jameslamb