Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] run r-package Linux jobs in containers #5638

Merged
merged 39 commits into from
Jan 10, 2023
Merged

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Dec 16, 2022

Follow-up to #5288 (especially #5288 (comment)).
Contributes to #5640.

Proposes the following:

  • running the R 4.x r-package Linux jobs in an ubuntu:22.04 container
  • running the R 3.6 r-package Linux jobs in an ubuntu:18.04 container
  • failing Linux and macOS CI builds if the R version used during tests was different from what was expected

This will help isolate those jobs from changes like #5186, and from accidentally relying on the many things GitHub Actions bundles into its VM images (e.g. click here to see what's in ubuntu-22.04).

Also happy to say this led to the discovery of a few other bugs in LightGBM!

How I tested this

Manually checked the logs of the r-package tests to ensure that R CMD check was really run, and that overall no new issues were introduced by these changes.

Also ran some builds that intentionally set modified the "are we using the expected version of R?" check to ensure that new check would really cause a CI failure.

@jameslamb jameslamb changed the title WIP: [ci] run r-package Linux jobs in containers [ci] run r-package Linux jobs in containers Dec 28, 2022
@jameslamb jameslamb marked this pull request as ready for review December 28, 2022 23:15
@jameslamb jameslamb requested a review from jmoralez December 28, 2022 23:15
@jameslamb jameslamb merged commit c2d2c99 into master Jan 10, 2023
@jameslamb jameslamb deleted the ci/r-package-containers branch January 10, 2023 19:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants