-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] run r-package Linux jobs in containers #5638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2022
jameslamb
changed the title
WIP: [ci] run r-package Linux jobs in containers
[ci] run r-package Linux jobs in containers
Dec 28, 2022
jmoralez
approved these changes
Jan 10, 2023
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5288 (especially #5288 (comment)).
Contributes to #5640.
Proposes the following:
r-package
Linux jobs in anubuntu:22.04
containerr-package
Linux jobs in anubuntu:18.04
containerThis will help isolate those jobs from changes like #5186, and from accidentally relying on the many things GitHub Actions bundles into its VM images (e.g. click here to see what's in ubuntu-22.04).
Also happy to say this led to the discovery of a few other bugs in LightGBM!
How I tested this
Manually checked the logs of the r-package tests to ensure that
R CMD check
was really run, and that overall no new issues were introduced by these changes.Also ran some builds that intentionally set modified the "are we using the expected version of R?" check to ensure that new check would really cause a CI failure.