Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'main' into 'release_mdd' #1414

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Merge 'main' into 'release_mdd' #1414

merged 4 commits into from
Aug 10, 2023

Conversation

WardenGnaw
Copy link
Member

No description provided.

WardenGnaw and others added 4 commits July 10, 2023 12:30
* Update version to 17.8
Co-authored-by: Andrew Wang <waan@microsoft.com>
DAR failed to set the encoding to UTF-8, leading to corrupt messages if we tried to marshal non-ascii strings.
* Only use ps 'flags' for macOS

This PR adds in an operating system check via uname to determine if we
should run the PS command with the 'flags' flag. This feature was
originally used to determine the architecture of a process for macOS M1
machines that can run as x64 or as arm64.

AD7Process only uses the flags field in macOS so this PR updates the
command sent to only use it on macOS machines.

Other changes:
- Updated the setup.csx script to update VS with VS.list instead of
  VS.Codespaces.list
- Updated tests to use the new PSOutputParser
- Added a macOS test

* Addressing PR issues
@WardenGnaw WardenGnaw merged commit c9f6960 into release_mdd Aug 10, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants