Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create initial github actions pipeline for building on windows #11

Merged
merged 6 commits into from
Aug 21, 2020
Merged

Create initial github actions pipeline for building on windows #11

merged 6 commits into from
Aug 21, 2020

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Aug 20, 2020

See Also #6

@bpkroth bpkroth self-assigned this Aug 20, 2020
@bpkroth bpkroth marked this pull request as ready for review August 20, 2020 16:51
@bpkroth bpkroth requested a review from a team August 20, 2020 16:51
@bpkroth bpkroth mentioned this pull request Aug 20, 2020
Merged
@bpkroth
Copy link
Contributor Author

bpkroth commented Aug 20, 2020

Note: msbuild also runs the uncrustify and stylecop checks for C++ and C# as well as the unit tests defined there.

After this, PR #12 will add Python checks to the CI pipelines.

@bpkroth
Copy link
Contributor Author

bpkroth commented Aug 21, 2020

Can someone in @microsoft/mlos-committers please sign-off on this?
I will start adding python checks after this.

amueller
amueller approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% familiar with the workflows but looks reasonable.

@bpkroth bpkroth merged commit 964c302 into main Aug 21, 2020
@bpkroth bpkroth deleted the bpkroth/msbuild-ci-actions-1 branch August 21, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@sergiy-k sergiy-k sergiy-k approved these changes

@grlap grlap Awaiting requested review from grlap

Assignees

@bpkroth bpkroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpkroth @amueller @sergiy-k