Add CI Action Pipelines for Python #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: here we run them on linux instead of windows for easier scripting, though (hopefully) the results are more or less that same in either spot (excepting for lf/crlf line ending differences which we should eventually fix separately)
- try to run some of the checks on both windows and linux - try to support a couple of different versions of python? - run the lint and unit tests from the same workspace (saves on some runner startup cost) - try to use the "approved" python setup task from github (else the PATH env doesn't seem to work out right)
This reverts commit 9ca6b96. Manually confirmed that this does indeed fail the build as expected.
Note: the commands still work on Linux, so for now let's try and skip providing separate scripts.
It's failing pylint checks with some "useless statement" warnings
bpkroth
force-pushed
the
bpkroth/python-ci-actions
branch
from
858269a
to
09fee67
Compare
sergiy-k
approved these changes
Aug 22, 2020
amueller
reviewed
Aug 24, 2020
bpkroth
commented
Aug 24, 2020
bpkroth
commented
Aug 24, 2020
amueller
approved these changes
Aug 24, 2020
bpkroth
pushed a commit
that referenced
this pull request
Sep 2, 2020
python documentation fixups from #12 and !422716
amueller
pushed a commit
that referenced
this pull request
Sep 2, 2020
python documentation fixups from #12 and !422716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of PR #11
See Also: Issue #6