bugfix: do not expand the script path in run/setup/teardown if it is not executable #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
reviewed
Jul 27, 2023
bpkroth
reviewed
Jul 27, 2023
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
bpkroth
approved these changes
Jul 27, 2023
motus
added a commit
that referenced
this pull request
Jul 28, 2023
Adds support for splitting a single shell command line into subcommands and applying the first token script name full path resolution logic to it. Also cleans up slightly the handling of `.` directories from #459. For example, in the following: ```sh . env.sh && partial/path/to/app/env/script.py || another/script.sh ``` `.` should be left alone as equivalent to the shell keyword `source`, and both scripts should resolved to an expanded full path, with the python script prefixed with a python executable path. Tests for both are included. --------- Co-authored-by: Sergiy Matusevych <sergiym@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for an actual executable is a bit tricky on Windows, so we'll do it properly later; (also, it is ok to have X bits not set for Python scripts). For now, add some minimal checks to prevent
.(as in. script.sh) from expanding into a current directory path instead of being treated assource script.shin bash.Also, remove extra newlines when logging the script's stdout/stderr.