Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlos_bench: shell command line parsing improvements #461

Merged
merged 12 commits into from
Jul 28, 2023

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Jul 27, 2023

Adds support for splitting a single shell command line into subcommands and applying the first token script name full path resolution logic to it.
Also cleans up slightly the handling of . directories from #459.
For example, in the following:

. env.sh && partial/path/to/app/env/script.py || another/script.sh

. should be left alone as equivalent to the shell keyword source, and both scripts should resolved to an expanded full path, with the python script prefixed with a python executable path.

Tests for both are included.

@bpkroth bpkroth requested a review from a team as a code owner July 27, 2023 21:46
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We can add more improvements later

@motus motus merged commit a891756 into microsoft:main Jul 28, 2023
11 checks passed
@bpkroth bpkroth mentioned this pull request Aug 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants