Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work to get C++ unit tests working in Linux CI #85

Merged
merged 21 commits into from
Sep 17, 2020
Merged

Work to get C++ unit tests working in Linux CI #85

merged 21 commits into from
Sep 17, 2020

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Sep 17, 2020

This is initial work to get C++ UnitTests (Mlos.UnitTest and SmartCache) working in Linux CI.

Main other issues it addresses:

  • Provide a mechanism for Linux to discover where to find the SettingsRegistry assemblies for the Mlos.Agent to load
  • DEBUG compile definition for MSVC compatibility
  • Skip (and comment) some failing unit tests on the dotnet side

There are some known issues with it, that @grlap and I discussed addressing in future PR:

  • print statements are not configurable, so while the output may be helpful in an interactive development environment, they aren't suitable for a service/daemon environment
  • there are some security concerns for loading settings registry DLLs are runtime
    • one solution there is to give the agent a config mechanism (file or args) to be able to choose whether it will allow runtime loadable DLLs at all

@bpkroth
include cmake test target in cake build for linux
7ba47c0 
Note: cake doesn't currently provide a ctest target, so we just call the
virtual "test" target that cmake generates to do the same.
@bpkroth
stub in a cmake test definition for running SmartCache with Mlos.Agen…
db9c309 
…t.Server

FIXME: as with Mlos.UnitTest - it currently hangs
@bpkroth
no need to hook that particular dotnet test into cmake
47a6287 
it's pure c# and called from the "dotnet test" target.
@bpkroth
add infrastructure for skipping certain dotnet tests by default
8d12260 
temporarily disabling since they're broken
@bpkroth
tweaks to vscode settings for easier initial debugging experience
3360ab5
@bpkroth
make sure that when we debug build, we define DEBUG for the compiler
3ac2c8c 
Typically, clang/gcc only define NDEBUG for Release builds, but don't
define DEBUG for other (e.g. Debug) builds.

This is to replicate MSVC behavior which defines DEBUG for Debug builds.

Without this, some UnitTests which were only supposed to run for Retail
builds due to failing asserts otherwise were getting build
unintentionally.
@bpkroth
quick hack to also treat files without any extension as executables f…
2f9eb45 
…or Linux
@bpkroth
just assume any file that doesn't end in a .json is an executable
5fe9114 
The previous method didn't work because for a binary named
"Mlos.UnitTest" standard path parsing tools think the extension is
".UnitTest"
@bpkroth
enabling the C++ unit tests via the agent server via ctest
81631fe
@bpkroth
some tweaks to try and get the output from the target process quicker
01995e1
@bpkroth
initial work to add some linux build/test work to the pipelines (just…
b93d832 
… dotnet for now)
@bpkroth
reorg and include cmake-build as well
6010568
@bpkroth
make sure some apt dependencies are installed
70dc748
@bpkroth
also run the cake build script for testing
ec103c4
@bpkroth
more vscode debugger improvements
2a80c96
@bpkroth
improvements to allow searching for the settings registry assembly in…
bfda72f 
… Linux environments

plus some other comments about eventual other fixups
@bpkroth
initial work on letting cmake run the c++ tests via ctest
15823be
@bpkroth
comments
3478259
@bpkroth
work around test fixtures only executing once
bf3cfe5 
This is a hack around the fact that we currently need to cleanup all of
the shared memory regions after ourselves before we can do another (or
different) run.
@bpkroth
add cmake test to the CI runs
441a6a9
@bpkroth bpkroth requested review from grlap and a team September 17, 2020 15:47
@bpkroth bpkroth merged commit 56e9517 into microsoft:main Sep 17, 2020
@bpkroth bpkroth mentioned this pull request Sep 25, 2020
Closed
@bpkroth bpkroth mentioned this pull request Oct 5, 2020
Closed
@bpkroth bpkroth deleted the bpkroth/linux-work branch March 20, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grlap grlap grlap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpkroth @grlap