Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work to get C++ unit tests working in Linux CI #85

Merged
merged 21 commits into from
Sep 17, 2020
Merged

Work to get C++ unit tests working in Linux CI #85

merged 21 commits into from
Sep 17, 2020

Commits on Sep 17, 2020

  1. include cmake test target in cake build for linux 

    Note: cake doesn't currently provide a ctest target, so we just call the
virtual "test" target that cmake generates to do the same.
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    7ba47c0 View commit details
    Browse the repository at this point in the history

  2. stub in a cmake test definition for running SmartCache with Mlos.Agen… 

    …t.Server

FIXME: as with Mlos.UnitTest - it currently hangs
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    db9c309 View commit details
    Browse the repository at this point in the history

  3. no need to hook that particular dotnet test into cmake 

    it's pure c# and called from the "dotnet test" target.
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    47a6287 View commit details
    Browse the repository at this point in the history

  4. add infrastructure for skipping certain dotnet tests by default 

    temporarily disabling since they're broken
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    8d12260 View commit details
    Browse the repository at this point in the history

  5. tweaks to vscode settings for easier initial debugging experience

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    3360ab5 View commit details
    Browse the repository at this point in the history

  6. make sure that when we debug build, we define DEBUG for the compiler 

    Typically, clang/gcc only define NDEBUG for Release builds, but don't
define DEBUG for other (e.g. Debug) builds.

This is to replicate MSVC behavior which defines DEBUG for Debug builds.

Without this, some UnitTests which were only supposed to run for Retail
builds due to failing asserts otherwise were getting build
unintentionally.
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    3ac2c8c View commit details
    Browse the repository at this point in the history

  7. quick hack to also treat files without any extension as executables f… 

    …or Linux
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    2f9eb45 View commit details
    Browse the repository at this point in the history

  8. just assume any file that doesn't end in a .json is an executable 

    The previous method didn't work because for a binary named
"Mlos.UnitTest" standard path parsing tools think the extension is
".UnitTest"
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5fe9114 View commit details
    Browse the repository at this point in the history

  9. enabling the C++ unit tests via the agent server via ctest

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    81631fe View commit details
    Browse the repository at this point in the history

  10. some tweaks to try and get the output from the target process quicker

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    01995e1 View commit details
    Browse the repository at this point in the history

  11. initial work to add some linux build/test work to the pipelines (just… 

    … dotnet for now)
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    b93d832 View commit details
    Browse the repository at this point in the history

  12. reorg and include cmake-build as well

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    6010568 View commit details
    Browse the repository at this point in the history

  13. make sure some apt dependencies are installed

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    70dc748 View commit details
    Browse the repository at this point in the history

  14. also run the cake build script for testing

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    ec103c4 View commit details
    Browse the repository at this point in the history

  15. more vscode debugger improvements

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    2a80c96 View commit details
    Browse the repository at this point in the history

  16. improvements to allow searching for the settings registry assembly in… 

    … Linux environments

plus some other comments about eventual other fixups
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    bfda72f View commit details
    Browse the repository at this point in the history

  17. initial work on letting cmake run the c++ tests via ctest

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    15823be View commit details
    Browse the repository at this point in the history

  18. comments

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    3478259 View commit details
    Browse the repository at this point in the history

  19. work around test fixtures only executing once 

    This is a hack around the fact that we currently need to cleanup all of
the shared memory regions after ourselves before we can do another (or
different) run.
    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    bf3cfe5 View commit details
    Browse the repository at this point in the history

  20. add cmake test to the CI runs

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    441a6a9 View commit details
    Browse the repository at this point in the history

  21. address some comments

    @bpkroth
    bpkroth committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    a839afd View commit details
    Browse the repository at this point in the history