Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtifactsSdkPredictor: Fix Artifact item name #113

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Sep 26, 2024

The item name is Artifact, not Artifacts.

https://github.com/microsoft/MSBuildSdks/blob/main/src/Artifacts/build/Microsoft.Build.Artifacts.Common.targets#L36

Also consider the $(EnableArtifacts) property.

@dfederm dfederm merged commit ca46097 into main Sep 26, 2024
3 checks passed
@dfederm dfederm deleted the dfederm/artifacts-item-fix branch September 26, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants