TryUnregisterModuleFolder now returns on path deletion

[Alexees]

Overview

The MixedRealityToolkitFiles.cs TryUnregisterModuleFolder iterates a foreach loop and deletes entries within it, but instead of exiting it sets a bool to true which it returns at the end continuing to iterate the loop resulting in an Exception.

Changes

Now returns on entry find.

Verification

I recognized that when I moved the MRTK generated folders over to another one and then removed the old folder.

[wiwei]

FYI, I think with the change here:

https://github.com/microsoft/MixedRealityToolkit-Unity/pull/5603/files

Going through all the mrtkFolders may actually be required - in practice, I don't think you'll actually see this really, but it might be good to keep this code as-is until the other PR goes in.

[wiwei]

Okay, I think that with the new changes highlighted in that PR this is going to be necessary to handle NuGet consumption cases, even if it doesn't show up in non-nuget cases

[wiwei]

If I hadn't made that other PR though, this would have been in a heartbeat

[Alexees]

@wiwei do you mean #5603, cause if so, this did not fix the problem. The loop still alters itself:

MixedRealityToolkit-Unity/Assets/MixedRealityToolkit/Utilities/Editor/Setup/MixedRealityToolkitFiles.cs

Lines 220 to 230 in 2367777

	foreach (var modFolders in mrtkFolders)
	{
	if (modFolders.Value.Remove(normalizedFolder))
	{
	if (modFolders.Value.Count == 0)
	{
	mrtkFolders.Remove(modFolders.Key);
	}
	found = true;
	}
	}