Skip to content

TryUnregisterModuleFolder now returns on path deletion #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alexees wants to merge 1 commit into from
Closed

TryUnregisterModuleFolder now returns on path deletion #5624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Assets/MixedRealityToolkit/Utilities/Editor/Setup/MixedRealityToolkitFiles.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ private static bool TryRegisterModuleFolder(string folder, out MixedRealityToolk
private static bool TryUnregisterModuleFolder(string folder)
{
string normalizedFolder = NormalizeSeparators(folder);
bool found = false;

foreach (var modFolders in mrtkFolders)
{
if (modFolders.Value.Remove(normalizedFolder))
Expand All @@ -193,11 +193,10 @@ private static bool TryUnregisterModuleFolder(string folder)
{
mrtkFolders.Remove(modFolders.Key);
}
found = true;
return true;
}
}

return found;
return false;
}

private static string NormalizeSeparators(string path) => path.Replace('\\', Path.DirectorySeparatorChar).Replace('/', Path.DirectorySeparatorChar);
Expand Down