Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable pinch/air tap thresholds for Leap Motion #7714

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Configurable pinch/air tap thresholds for Leap Motion #7714

merged 2 commits into from
Apr 23, 2020

Conversation

CDiaz-MS
Copy link
Contributor

Overview

Added configurable pinch thresholds for a Leap Motion hand.

New Inspector Current Value Appearance
PinchConfigure LeapPinchAfter

Changes

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@CDiaz-MS CDiaz-MS added Cross Platform Platform - Leap Motion Issues related to Leap Motion hand tracking labels Apr 23, 2020
@CDiaz-MS CDiaz-MS requested review from julenka, keveleigh and wiwei April 23, 2020 01:34
julenka
julenka approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@julenka julenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Consider adding a note in the documentation about the enter and exit pinch distances, regarding "configuring pinch sensitivity".

@CDiaz-MS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CDiaz-MS
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CDiaz-MS CDiaz-MS merged commit 56db6ec into microsoft:prerelease/2.4.0_stabilization Apr 23, 2020
@david-c-kline david-c-kline added this to the MRTK 2.4.0 milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julenka julenka julenka approved these changes

@david-c-kline david-c-kline david-c-kline approved these changes

@keveleigh keveleigh Awaiting requested review from keveleigh

@wiwei wiwei Awaiting requested review from wiwei

Assignees
No one assigned
Labels
Cross Platform Platform - Leap Motion Issues related to Leap Motion hand tracking
Projects
None yet
Milestone
MRTK 2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CDiaz-MS @julenka @david-c-kline