Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "failed to fetch()" error #491

Merged
merged 15 commits into from
Aug 14, 2020

Conversation

alex-krasn
Copy link
Contributor

No description provided.

@alex-krasn alex-krasn linked an issue Aug 12, 2020 that may be closed by this pull request
@alex-krasn alex-krasn requested review from kunzms and stew-ro August 12, 2020 20:23
@alex-krasn alex-krasn changed the title add try-catch for fetch() fix: add try-catch for fetch() Aug 12, 2020
kunzms
kunzms previously approved these changes Aug 12, 2020
@alex-krasn alex-krasn changed the title fix: add try-catch for fetch() fix: "failed to fetch()" error Aug 13, 2020
@alex-krasn alex-krasn merged commit 530545c into master Aug 14, 2020
@alex-krasn alex-krasn deleted the alex-krasn/fix-failed-to-fetch-error-#489 branch August 14, 2020 22:50
alex-krasn added a commit that referenced this pull request Sep 30, 2020
* add try-catch for fetch()

* use poll function instead try-catch

* style: naming

* fix: poll and resolve for fetched failed

* add try-catch for fetch()

* use poll function instead try-catch

* style: naming

* merge + misc

* deletes unused import

* fix: check for failed fetch promise

* since it's not blocking error - console.err(message) instead 'toast'

* switch to console.err for spooded mime type too

Co-authored-by: stew-ro <v-stewro@microsoft.com>
alex-krasn added a commit that referenced this pull request Sep 30, 2020
* add try-catch for fetch()

* use poll function instead try-catch

* style: naming

* fix: poll and resolve for fetched failed

* add try-catch for fetch()

* use poll function instead try-catch

* style: naming

* merge + misc

* deletes unused import

* fix: check for failed fetch promise

* since it's not blocking error - console.err(message) instead 'toast'

* switch to console.err for spooded mime type too

Co-authored-by: stew-ro <v-stewro@microsoft.com>

Co-authored-by: stew-ro <v-stewro@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOTT bug report
3 participants