-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "failed to fetch()" error #491
Merged
alex-krasn
merged 15 commits into
master
from
alex-krasn/fix-failed-to-fetch-error-#489
Aug 14, 2020
Merged
fix: "failed to fetch()" error #491
alex-krasn
merged 15 commits into
master
from
alex-krasn/fix-failed-to-fetch-error-#489
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kunzms
previously approved these changes
Aug 12, 2020
stew-ro
reviewed
Aug 12, 2020
alex-krasn
changed the title
fix: add try-catch for fetch()
fix: "failed to fetch()" error
Aug 13, 2020
…rror-#489' into alex-krasn/fix-failed-to-fetch-error-#489
stew-ro
reviewed
Aug 14, 2020
…into alex-krasn/fix-failed-to-fetch-error-#489
…ithub.com/microsoft/OCR-Form-Tools into alex-krasn/fix-failed-to-fetch-error-#489
stew-ro
approved these changes
Aug 14, 2020
alex-krasn
added a commit
that referenced
this pull request
Sep 30, 2020
* add try-catch for fetch() * use poll function instead try-catch * style: naming * fix: poll and resolve for fetched failed * add try-catch for fetch() * use poll function instead try-catch * style: naming * merge + misc * deletes unused import * fix: check for failed fetch promise * since it's not blocking error - console.err(message) instead 'toast' * switch to console.err for spooded mime type too Co-authored-by: stew-ro <v-stewro@microsoft.com>
alex-krasn
added a commit
that referenced
this pull request
Sep 30, 2020
* add try-catch for fetch() * use poll function instead try-catch * style: naming * fix: poll and resolve for fetched failed * add try-catch for fetch() * use poll function instead try-catch * style: naming * merge + misc * deletes unused import * fix: check for failed fetch promise * since it's not blocking error - console.err(message) instead 'toast' * switch to console.err for spooded mime type too Co-authored-by: stew-ro <v-stewro@microsoft.com> Co-authored-by: stew-ro <v-stewro@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.