cherry-pick 530545c -- fix: "failed to fetch()" error (#491) #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add try-catch for fetch() * use poll function instead try-catch * style: naming * fix: poll and resolve for fetched failed * add try-catch for fetch() * use poll function instead try-catch * style: naming * merge + misc * deletes unused import * fix: check for failed fetch promise * since it's not blocking error - console.err(message) instead 'toast' * switch to console.err for spooded mime type too Co-authored-by: stew-ro <v-stewro@microsoft.com>
stew-ro
approved these changes
Sep 30, 2020
kunzms
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add try-catch for fetch()
use poll function instead try-catch
style: naming
fix: poll and resolve for fetched failed
add try-catch for fetch()
use poll function instead try-catch
style: naming
merge + misc
deletes unused import
fix: check for failed fetch promise
since it's not blocking error - console.err(message) instead 'toast'
switch to console.err for spooded mime type too
Co-authored-by: stew-ro v-stewro@microsoft.com