Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation does not complete #32341

Closed
benhur2407 opened this issue Apr 8, 2024 · 29 comments
Closed

Installation does not complete #32341

benhur2407 opened this issue Apr 8, 2024 · 29 comments
Labels
Area-Setup/Install Refers to installation mechanism Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@benhur2407
Copy link

Microsoft PowerToys version

0.80.0

Installation method

PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

General

Steps to reproduce

PowerToysReport_2024-04-08-18-56-52.zip

✔️ Expected Behavior

Installation completed

❌ Actual Behavior

Installation starts but installation screen disappears and then nothing happens.

Other Software

No response

@benhur2407 benhur2407 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@benhur2407
Copy link
Author

Problem lies with the fact the My Documents folder is on a network drive. On previous versions, this did not cause any problem.

@jaimecbernardo
Copy link
Collaborator

From the logs:
"Invalid Drive: V:"
"PersonalFolder = V:\Mes Documents"

On 0.80 we are installing files there for DSC. Perhaps we can make those non vital and check if that works? 🤔

@jaimecbernardo
Copy link
Collaborator

@benhur2407 ,
Can you please try out https://github.com/jaimecbernardo/PowerToys/releases/tag/v0.0.1-test-issue-32341 ?
That's a locally built (non signed) installed that marks the dsc files we're saving in "My Documents" as not vital.
Can you please uninstall your current PowerToys installation and install this one to verify if it solves your issue?
Would be good if we could try this out in time for the hotfix that we'll be releasing soon.
Thanks, in advance.
/needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 9, 2024
@davidegiacometti davidegiacometti added the Area-Setup/Install Refers to installation mechanism label Apr 9, 2024
@jaimecbernardo jaimecbernardo self-assigned this Apr 9, 2024
@jaimecbernardo jaimecbernardo added the Status-In progress This issue or work-item is under development label Apr 9, 2024
@benhur2407
Copy link
Author

I tried the proposed installer and it works like a charm. Looking forward for this change in 0.81 Release. Thanks.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 9, 2024
@jaimecbernardo
Copy link
Collaborator

Thanks for verifying!

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 9, 2024

Is this fix committed then?

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Hot Fix Items we will product an out-of-band release for and removed Status-In progress This issue or work-item is under development Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Apr 9, 2024
@jaimecbernardo
Copy link
Collaborator

Yes, We'll be releasing it in a 0.80.1 hotfix in the next few days.

@benhur2407
Copy link
Author

Tank you very much for taking care of this so promptly.

@JessePeden
Copy link

0.80.1 did not fix this issue.

@benhur2407
Copy link
Author

I concur. Issue is still present in 0.80.1

@jaimecbernardo
Copy link
Collaborator

Ah, before you were trying to use the user installer and now it's the machine installer? 🤔 Wonder if that's the issue.

@htcfreek
Copy link
Collaborator

htcfreek commented Apr 12, 2024

What's "Eigene Dateien"?
This one is looking weird.
Can we please get the installer logs from 0.80.1 that you're getting?

It is the German word for the "My Documents" folder (C:\Users\%Username%\My Documemts) on Win XP. That's indeed weird.

@benhur2407
Copy link
Author

Just tried the user installer and I get the same error. See attached log.

powertoys-bootstrapper-msi-0.80.1_20240412131423_001_PowerToysUserSetup_0.80.1_x64.msi.log

@dkeitzel
Copy link

What's "Eigene Dateien"?
This one is looking weird.
Can we please get the installer logs from 0.80.1 that you're getting?

As @htcfreek said, it's the german 'My Documents' equivalent. That folder resides on a network share. Here are the two log files with some redacted personal information:

powertoys-bootstrapper-msi-0.80.1_20240412063729.log
powertoys-bootstrapper-msi-0.80.1_20240412063729_001_PowerToysSetup_0.80.1_x64.msi.log

@htcfreek
Copy link
Collaborator

What's "Eigene Dateien"?
This one is looking weird.
Can we please get the installer logs from 0.80.1 that you're getting?

As @htcfreek said, it's the german 'My Documents' equivalent. That folder resides on a network share. Here are the two log files with some redacted personal information:

powertoys-bootstrapper-msi-0.80.1_20240412063729.log
powertoys-bootstrapper-msi-0.80.1_20240412063729_001_PowerToysSetup_0.80.1_x64.msi.log

I did not check the logs. But that sounds like a problem with folder redirection.

@dkeitzel
Copy link

I did not check the logs. But that sounds like a problem with folder redirection.

Thinking the same. I have active folder redirections for various user shell folders that point to network shares. For example:

Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Folders\Personal =      \\$REMOTE\Benutzer\$USER\Eigene Dateien
Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\User Shell Folders\Personal = \\$REMOTE\Benutzer\$USER\Eigene Dateien

@2CmPw6
Copy link

2CmPw6 commented Apr 15, 2024

I too am getting issues since v0.79.0, same issue, My Documents is mapped to a network drive/mount. v0.80.1 did not resolve the problem for me.

@yuyoyuppe
Copy link
Collaborator

Hey @dkeitzel, I'm trying to reproduce the issue locally on my Windows 11 VM machine and I wonder how you did your setup.

What I did:

  • created an admin user "Aaron" and changed the same registry entries as you've posted to \\tsclient\P\aaron_home
  • launched PowerToys user installer

However, I'm getting the following error:
image

Not sure why the dot is being appended 🤔

@dkeitzel
Copy link

Hi @yuyoyuppe. Not sure either. What I can say is that I'm not an admin on my maschine. Furthermore I'm running Windows 10 Enterprise, not Windows 11. I also did not use the user installer, but the normal "system" one.

I assume the user has access to that share?

@2CmPw6
Copy link

2CmPw6 commented Apr 23, 2024

Hi @yuyoyuppe, not sure if this helps...

I'm using Window 10, in Explorer, mount a Network share as a Drive (J: in my case), view the properties of My Documents folder and select the "Location" tab and "Move" the folder to the Mounted drive (or sub-dir on the mount).

Attempt to install an update >0.79.0, either from the PowerToys Admin panel or via the MSI directly (the latter will/should display a drive error)

HTH

@jaimecbernardo
Copy link
Collaborator

We've figured out how to fix this for machine installer. #32691
Still looking for a fix for user install while still being able to install the DSC module.

@jaimecbernardo jaimecbernardo added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 8, 2024
@2CmPw6
Copy link

2CmPw6 commented May 22, 2024

I've just been notified of an update to 0.81.0 and can confirm that the update went smoothly! Thanks for sorting the issue, really appreciate the effort and time you devs put into the PowerToys project and bug fixes!

@jaimecbernardo
Copy link
Collaborator

Thanks for the feedback!
For everyone who still has issues with the user install, the current workaround is to uninstall the user scope installation and to install with the machine scope installer instead.

@jaimecbernardo jaimecbernardo added this to the PowerToys 0.82 milestone Jun 19, 2024
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 19, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Jul 9, 2024

This was released wit v0.82.0.

@htcfreek htcfreek closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Setup/Install Refers to installation mechanism Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Development

No branches or pull requests

8 participants