-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64 pending modules #17972
Arm64 pending modules #17972
Conversation
🔥🔥🔥🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the diff, some of these contain full file changes? why is this the case? some line ending / whitespace changes?
Could you check those to make sure what the correct push should be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..etc.. We can make a big cleanup here in bunch of proj files
</ImportGroup> | ||
<PropertyGroup Label="UserMacros" /> | ||
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'"> | ||
</ImportGroup> <PropertyGroup Label="UserMacros" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line should be here between and <PropertyGroup
src/modules/MouseUtils/MousePointerCrosshairs/MousePointerCrosshairs.vcxproj
Outdated
Show resolved
Hide resolved
<PropertyGroup Condition="'$(Configuration)'=='Debug'"> | ||
<TargetName>PowerToys.ShortcutGuideModuleInterface</TargetName> | ||
</PropertyGroup> | ||
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'"> | ||
<PropertyGroup Condition="'$(Configuration)'=='Release'"> | ||
<TargetName>PowerToys.ShortcutGuideModuleInterface</TargetName> | ||
</PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this - targetname unconditional
src/modules/powerrename/PowerRenameUILib/PowerRenameUILib.vcxproj
Outdated
Show resolved
Hide resolved
src/modules/powerrename/PowerRenameUILib/PowerRenameUILib.vcxproj
Outdated
Show resolved
Hide resolved
I will clean these up and get updates in. A lot of the updates I made for the other projects were done with simplification to the logic afterwards. |
@yuyoyuppe - Can you grant me contributor rights to your PowerToys repo? I have a local commit full of fixes and didn't realize that GitHub checked out the branch from YOUR repo :) |
@snickler invited :) |
Looks like all of the comments by @stefansjfw are resolved. @jaimecbernardo, looking at Maybe we should also fill our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work! Did you try to build an x64 installer from this and test to verify it works? (Testing changed PowerToys as well)
I've rebased on the latest main to include 3da341f and tested all modules - they appear to work using the local x64 installer. |
833c0a7
to
67dfe13
Compare
Thank you. I'll squash and merge once the tests pass. |
Summary of the Pull Request
What is this about:
This PR contains contributions from @snickler as part of the patch to add ARM64 configuration to PowerToys. I've split the work across projects to multiple commits for easier reviewing and attributed commits to the author. Thanks a lot, Jeremy!
This PR doesn't add PowerToys.sln changes to include arm64 configuration - that'd be a separate PR.
What is included in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.