-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM64]CI and build pipelines #18337
Conversation
(opened the draft PR in order to run the CI pipelines to check for errors) |
88a699f
to
102bef7
Compare
@yuyoyuppe @crutkas , It's ready for review. @crutkas , please check the changes to publishing on nuget. Is arm64 nuget something we want to do? |
@@ -6,6 +6,7 @@ | |||
<OutputPath>$(SolutionDir)$(Platform)\$(Configuration)\modules\ColorPicker</OutputPath> | |||
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> | |||
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath> | |||
<GenerateSatelliteAssembliesForCore>true</GenerateSatelliteAssembliesForCore> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add it as part of Directory.props file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is project specific, though. Only for C# projects with localization. No idea if there's a downside otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus, directory.props doesn't propagate for publishing directly from the csproj, so it would still need it in the project files for projects that are published.
so excited!! |
@@ -21,7 +21,7 @@ jobs: | |||
$github = Invoke-RestMethod -uri "https://api.github.com/repos/Microsoft/PowerToys/releases" | |||
|
|||
$targetRelease = $github | Where-Object -Property name -match 'Release'| Select -First 1 | |||
$installerUrl = $targetRelease | Select -ExpandProperty assets -First 1 | Where-Object -Property name -match 'PowerToysSetup' | Select -ExpandProperty browser_download_url | |||
$installerUrl = $targetRelease | Select -ExpandProperty assets -First 1 | Where-Object -Property name -match 'PowerToysSetup.*x64' | Select -ExpandProperty browser_download_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is grabbing only x64. The script needs larger tweaks after a manual step to include arm. I created an issue to track.
😍😍 |
Summary of the Pull Request
What is this about:
Builds both x64 and arm64 on CI and build Pipelines.
What is included in the PR:
x64
andarm64
jobs in CI and release pipelines.GenerateSatelliteAssembliesForCore
to the projects that require localization, to avoid using ALINK (al.exe
) in the CI, which doesn't supportarm64
.arm64
name and output paths (hacks for thex86
installer workaround should be placed locally nearer the place of thex86
hack than farther on the pipelines). This should be cleared once we update Wix to a version that supportsarm64
installers.build-installer-MSI.cmd
, which is no longer used.How does someone test / validate:
CI and release pipelines are able to build both
x64
andarm64
. (No arm64 tests run in CI yet. Not sure we have agents for that)Quality Checklist