Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerRename] Suppress redundant midl warning #29070

Merged

Conversation

yuyoyuppe
Copy link
Contributor

Summary of the Pull Request

Removes these warnings:

1>Processing WinMD c:\program files (x86)\windows kits\10\references\10.0.20348.0\windows.ui.xaml.core.direct.xamldirectcontract\3.0.0.0\windows.ui.xaml.core.direct.xamldirectcontract.winmd
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"GetAt" has been renamed as "Windows.Foundation.Collections.IVector`1<Object>.GetAt" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"GetAt" has been renamed as "Windows.Foundation.Collections.IVectorView`1<Object>.GetAt" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"get_Size" has been renamed as "Windows.Foundation.Collections.IVectorView`1<Object>.get_Size" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"Size" has been renamed as "Windows.Foundation.Collections.IVectorView`1<Object>.Size" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"get_Size" has been renamed as "Windows.Foundation.Collections.IVector`1<Object>.get_Size" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"Size" has been renamed as "Windows.Foundation.Collections.IVector`1<Object>.Size" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"IndexOf" has been renamed as "Windows.Foundation.Collections.IVector`1<Object>.IndexOf" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"IndexOf" has been renamed as "Windows.Foundation.Collections.IVectorView`1<Object>.IndexOf" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"GetMany" has been renamed as "Windows.Foundation.Collections.IVector`1<Object>.GetMany" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>..\PowerToys\src\modules\powerrename\PowerRenameUILib\ExplorerItemsSource.idl(9): warning MIDL4066: [msg]A member name has been qualified with an interface name because name collisions occurred across interface members on a runtime class. [context]"GetMany" has been renamed as "Windows.Foundation.Collections.IVectorView`1<Object>.GetMany" on runtime class "PowerRenameUI.ExplorerItemsSource"
1>Done building project "PowerRenameUI.vcxproj".

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that warning are gone

@jaimecbernardo jaimecbernardo merged commit 2991da5 into microsoft:main Oct 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants