[ARM64] Fix Preview Handlers #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyoyuppe
approved these changes
Apr 22, 2022
| @@ -12,7 +12,6 @@ | |||
| <EnableNETAnalyzers>true</EnableNETAnalyzers> | |||
| <AnalysisMode>Recommended</AnalysisMode> | |||
| <PlatformTarget>$(Platform)</PlatformTarget> | |||
| <Platforms>$(Platform)</Platforms> | |||
There was a problem hiding this comment.
Because it's up there in the file already. This is a re-declaration.
| @@ -10,3 +10,11 @@ msbuild !PTRoot!\src\settings-ui\Settings.UI\PowerToys.Settings.csproj -t:Publis | |||
|
|
|||
| rem In case of Release we should not use Debug CRT in VCRT forwarders | |||
| msbuild !PTRoot!\src\modules\launcher\PowerLauncher\PowerLauncher.csproj -t:Publish -p:Configuration="Release" -p:Platform="!PlatformArg!" -p:AppxBundle=Never -p:PowerToysRoot=!PTRoot! -p:VCRTForwarders-IncludeDebugCRT=false -p:PublishProfile=InstallationPublishProfile.pubxml | |||
|
|
|||
| msbuild !PTRoot!\src\modules\previewpane\MonacoPreviewHandler\MonacoPreviewHandler.csproj -t:Publish -p:Configuration="Release" -p:Platform="!PlatformArg!" -p:AppxBundle=Never -p:PowerToysRoot=!PTRoot! -p:VCRTForwarders-IncludeDebugCRT=false -p:PublishProfile=InstallationPublishProfile.pubxml | |||
There was a problem hiding this comment.
so, do we need to publish all .net 6 apps?
There was a problem hiding this comment.
Just the ones that have native runtime dlls, so that the correct one is picked. (These all use WebView2)
yuyoyuppe
added a commit
that referenced
this pull request
May 24, 2022
* [ARM64] Cleanup PowerToys solution configuration * [ARM64] Add Bootstrapper support known issues: - wix doesn't have arm platform -> using x86 instead, resulting in wrong default installation dir and inability to detect 605 - current winappsdk 1.0.3 installer is corrupted -> contains x64 packages - we're still using hardcoded vcredist for some modules * Remove duplicate Stylecop PackageReference * [ARM64] Cleanup StylesReportTool configuration * [ARM64] fix configurations for bootstrapper * fixes * [ARM64] VCM fix * [ARM64] Fix LinkIncremental conditional in StylesReportTool * fix #2 * perfect forwarding * [ARM64] Switch to call vformat to compile with later MSVC toolkits * Updated expect Co-authored-by: Jeremy Sinclair <4016293+snickler@users.noreply.github.com>
yuyoyuppe
pushed a commit
that referenced
this pull request
May 25, 2023
…0587) * Adding unicode names and adjusting UI (WIP) * Added changing letter names * Add optioins to hide description (WIP) * WIP * Change to binding property * Adress PR comments * Set TextBlock in border * * Added to settings * Fixed string showing/not showing one time after switching character * Removed unneccessairy command in SettingsService.cs * Moved showdescription enum to settings.ui * Adding Fluent design :) * Fix merge errors * Center list * Fixed code not working. Accepted some code style changes. * Merge main in branch #2 * [Quick Accent] support unicode description for UTF-16 surrogate pairs * [Quick Accent] fix check-spelling-bot errors * [check-spelling] accept LANGID as correct word * [Quick Accent] fix delay when calling ShowToolbar for the first time * [Quick Accent] use toggle switch to turn off/on Unicode description * [Quick Accent] fix after merge * [Quick Accent] add UnicodeInformation.dll to installer Co-authored-by: Niels Laute <niels.laute@live.nl>
yuyoyuppe
pushed a commit
that referenced
this pull request
Jun 9, 2023
yuyoyuppe
added a commit
that referenced
this pull request
Oct 10, 2023
* [PowerRename] Suppress redundant midl warning * spelling * f: spelling #2 * spelling 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix preview handlers by publishing the ones that require native libs for WebView2 and fix installer now that we publish.