Add UITest Cases for Hosts Module and Improve UITestAutomation #37546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a. Adding Entry b. Empty View - Update UITest Framework, including: a. Add Pre/Post timeout for Click action. b. Add TextBox control which allow get/set Text c. Add more properties in Element Control. d. Remove unnecessary Assert in FindAll e. Add Shortcut (Find/FindAll) in TestBase to keep test-code shorter. f. Move FindHelper to root folder of UIAutomation project. g. Add ToggleSwitch control - Update PowerToys solution file to address inconsistent naming convention
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- PowerToys.sln: Language not supported
- src/common/UITestAutomation/UITestAutomation.csproj: Language not supported
- src/modules/Hosts/Hosts.UITests/Hosts.UITests.csproj: Language not supported
- src/common/UITestAutomation/Element/Window.cs: Evaluated as low risk
- src/common/UITestAutomation/UITestBase.cs: Evaluated as low risk
- src/common/UITestAutomation/Session.cs: Evaluated as low risk
- src/common/UITestAutomation/FindHelper.cs: Evaluated as low risk
This comment has been minimized.
This comment has been minimized.
remove new from zoomit
urnotdfs
reviewed
Feb 20, 2025
| { | ||
| if (clearText) | ||
| { | ||
| PerformAction((actions, window) => |
There was a problem hiding this comment.
The current PerformAction method may not be suitable for SetText because it is designed for click actions and only calls MoveToElement. For TextBox, to simulate manual operation, it should move the mouse to the element and then click it. There are may two possible ways:
- Call the click function, and then directly call sendKeys.
- Create a new PerformAction method specifically for SetText
There was a problem hiding this comment.
I think it would be better to have preTimeout, Operations & postTimeout pattern setup, which is something like PerformAction.
design it only for click is not idea.
There was a problem hiding this comment.
And it would also be better to rename the 'window' here.
…om/microsoft/PowerToys into dev/nxu/AddUITestForHostFileModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UITest cases for Hosts module, and Improve UITestAutomation framework by adding more features, fixing bugs.
Please take a look screen-recording here for reference:
https://github.com/user-attachments/assets/49b5b611-3dc7-43fd-ae6a-185ea8bc7e9b
PR Checklist
Detailed Description of the Pull Request / Additional comments
Changes including:
Add UITests for Hosts module
a. Add test for Adding-entry function
b. Add test for Empty-View
Update UITestAutomation Framework
a. Add Pre/Post timeout for Click action.
b. Add TextBox control which allow get/set Text
c. Add more properties in Element Control.
d. Remove unnecessary Assert in FindAll
e. Add Shortcut (Find/FindAll) in TestBase to keep test-code shorter.
f. Move FindHelper to root folder of UIAutomation project.
g. Add ToggleSwitch control
Update PowerToys solution file to address inconsistent naming convention
Validation Steps Performed