Skip to content

feature/spaceship: Merge #1049 (fix <compare> and simplify guards) #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 6 commits into from
Jul 21, 2020
Merged

feature/spaceship: Merge #1049 (fix <compare> and simplify guards) #1064

StephanTLavavej merged 6 commits into from
Jul 21, 2020

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jul 21, 2020

Note to self: Commit this as a merge, not as a squash!

miscco and others added 6 commits July 16, 2020 21:54
@miscco @StephanTLavavej
Implement ranges::transform (#941)
002cdc6 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@miscco
Implement ranges::remove family (#1005)
16db993
@Chronial
Use permissive wide-to-narrow transcoding in filesystem_error (#1010)
0965ada
@CaseyCarter @StephanTLavavej
Implement ranges::copy_backward (#1026)
21acd23 
* Implement ranges::copy_backward

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter @ahanamuk
Implement ranges::reverse (#1028)
4f949af 
Co-authored-by: Ahana Mukhopadhyay <t-ahmukh@microsoft.com>
@CaseyCarter @statementreply @StephanTLavavej
<compare>: Fix 0 <=> partial_ordering::unordered (#1049)
7930d35 
* Break <compare> ABI again, and fix #1050.

* Remove obsolete conditional compilation from <compare>.

Co-authored-by: statementreply <statementreply@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@StephanTLavavej StephanTLavavej added the spaceship C++20 operator <=> label Jul 21, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner July 21, 2020 00:22
@StephanTLavavej StephanTLavavej self-assigned this Jul 21, 2020
@StephanTLavavej StephanTLavavej merged commit de04d41 into feature/spaceship Jul 21, 2020
@StephanTLavavej StephanTLavavej added the uncharted Excluded from the Status Chart label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

spaceship C++20 operator <=> uncharted Excluded from the Status Chart

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@StephanTLavavej @CaseyCarter @miscco @Chronial