Skip to content

Conversation

@StephanTLavavej
Copy link
Member

This ports MSVC-PR-269581, reverting GH-986 / MSVC-PR-240462.

According to John Morgan:

We recently discovered a conflict between the 64-bit Interlocked
intrinsic functions newly implemented for x86 and the Windows 8.1 SDK.
To resolve the conflict we are reverting the change. We may later
implement an alternative solution to support these functions on x86.

This ports MSVC-PR-269581, reverting microsoftGH-986 / MSVC-PR-240462.

According to John Morgan:

> We recently discovered a conflict between the 64-bit Interlocked
> intrinsic functions newly implemented for x86 and the Windows 8.1 SDK.
> To resolve the conflict we are reverting the change. We may later
> implement an alternative solution to support these functions on x86.
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Aug 22, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 22, 2020 01:29
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove #1018, or repurpose it to remove the new codepaths for Clang as well?

@StephanTLavavej
Copy link
Member Author

We should probably tell Clang that we're reverting the change, so no action is requested from them at this time, if I understand this correctly.

@CaseyCarter
Copy link
Contributor

We should probably tell Clang that we're reverting the change, so no action is requested from them at this time, if I understand this correctly.

I think I was trying to say "We should close #1018 and continue to use the same codepaths for Clang and MSVC instead of taking advantage of these intrinsics that we asked for which now will only exist on Clang." but apparently got lost along the way.

@AlexGuteniev
Copy link
Contributor

Clang folks may need to revert their change as well -- for the same reason.

Honestly I'd prefer hacking around the SDK instead.

@StephanTLavavej
Copy link
Member Author

I realized that Clang might not care about compatibility with the ancient Win8.1 SDK. However, I agree about #1018 and will go close it now.

@StephanTLavavej StephanTLavavej self-assigned this Aug 26, 2020
@StephanTLavavej StephanTLavavej merged commit 2bec360 into microsoft:master Aug 26, 2020
@StephanTLavavej StephanTLavavej deleted the atomic_revert branch August 26, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants