VS 2019 16.8 Preview 2 toolset upgrade #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Aug 26, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Surprise! _InterlockedExchange128_nf is not in intrin0.h in 16.8p2; it will be in 16.8p3. I'll push a fix.
`_InterlockedExchange128_nf` is _not_ defined in `<intrin0.h>` in 16.8p2. That change is coming in Preview 3.
CaseyCarter
approved these changes
Aug 26, 2020
cbezault
approved these changes
Aug 26, 2020
CaseyCarter
approved these changes
Aug 26, 2020
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Excellent catch, thanks! Yes, I totally forgot, and yes, it should be in the checklist. I'll fix it up and then send out an MSVC-PR internally. |
CaseyCarter
approved these changes
Aug 26, 2020
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally changes
create-vmss.ps1to stop on errors. (When I attempt to update the VMSS while all of our cores are busy processing PR/CI builds, the script fails - now it immediately exits after encountering the quota limit, instead of proceeding and getting confused as to why it can't shut down a nonexistent VM.)