Skip to content

VS 2019 16.8 Preview 2 toolset upgrade #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 7 commits into from
Aug 27, 2020
Merged

VS 2019 16.8 Preview 2 toolset upgrade #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2c7ed46
create-vmss.ps1 should stop on errors.
StephanTLavavej Aug 26, 2020
cdb42df
VS 2019 16.8 Preview 2 toolset.
StephanTLavavej Aug 26, 2020
0381c54
_InterlockedExchange128_nf fix
CaseyCarter Aug 26, 2020
adcc41d
Try harder
CaseyCarter Aug 26, 2020
5658a34
tuple.cnstr/test_lazy_sfinae.pass.cpp is now passing.
StephanTLavavej Aug 26, 2020
23bcd75
Update preprocessor comment.
StephanTLavavej Aug 26, 2020
c142cc4
Update README.md.
StephanTLavavej Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ Just try to follow these rules, so we can spend more time fixing bugs and implem
The STL uses boost-math headers to provide P0226R1 Mathematical Special Functions. We recommend using [vcpkg][] to
acquire this dependency.

1. Install Visual Studio 2019 16.8 Preview 1 or later.
1. Install Visual Studio 2019 16.8 Preview 2 or later.
* We recommend selecting "C++ CMake tools for Windows" in the VS Installer.
This will ensure that you're using supported versions of CMake and Ninja.
* Otherwise, install [CMake][] 3.17 or later, and [Ninja][] 1.8.2 or later.
Expand All @@ -158,7 +158,7 @@ acquire this dependency.

# How To Build With A Native Tools Command Prompt

1. Install Visual Studio 2019 16.8 Preview 1 or later.
1. Install Visual Studio 2019 16.8 Preview 2 or later.
* We recommend selecting "C++ CMake tools for Windows" in the VS Installer.
This will ensure that you're using supported versions of CMake and Ninja.
* Otherwise, install [CMake][] 3.17 or later, and [Ninja][] 1.8.2 or later.
Expand Down
2 changes: 2 additions & 0 deletions azure-devops/create-vmss.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ at https://docs.microsoft.com/en-us/powershell/azure/install-az-ps
or are running from Azure Cloud Shell.
#>

$ErrorActionPreference = 'Stop'

$Location = 'westus2'
$Prefix = 'StlBuild-' + (Get-Date -Format 'yyyy-MM-dd')
$VMSize = 'Standard_D16as_v4'
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Build STL targeting x86, x64, arm, arm64

variables:
agentPool: 'StlBuild-2020-08-11'
agentPool: 'StlBuild-2020-08-26'
tmpDir: 'D:\Temp'

stages:
Expand Down
4 changes: 2 additions & 2 deletions stl/inc/xatomic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

#include <intrin0.h>
#include <type_traits>
#if defined(_WIN64) && (_MSC_FULL_VER < 192829203) // TRANSITION
#if defined(_WIN64) && (_MSC_FULL_VER <= 192829213) // TRANSITION
#include <intrin.h> // Visual Studio 2019 to define 128-bit CAS in <intrin0.h>
#endif // defined(_WIN64) && (_MSC_FULL_VER < 192829203), TRANSITION
#endif // defined(_WIN64) && (_MSC_FULL_VER <= 192829213), TRANSITION

#pragma pack(push, _CRT_PACKING)
#pragma warning(push, _STL_WARNING_LEVEL)
Expand Down
3 changes: 0 additions & 3 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,6 @@ std/thread/futures/futures.task/futures.task.members/make_ready_at_thread_exit.p


# *** C1XX COMPILER BUGS ***
# Compiler bug: VSO-106654 "error C2580 "multiple versions of a defaulted special member functions are not allowed" is bogus and ungrammatical"
std/utilities/tuple/tuple.tuple/tuple.cnstr/test_lazy_sfinae.pass.cpp:0 FAIL

# Compiler bug: DevCom-409222 "Constructing rvalue reference from non-reference-related lvalue reference"
std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp:0 FAIL

Expand Down
3 changes: 0 additions & 3 deletions tests/libcxx/skipped_tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,6 @@ thread\futures\futures.task\futures.task.members\make_ready_at_thread_exit.pass.


# *** C1XX COMPILER BUGS ***
# Compiler bug: VSO-106654 "error C2580 "multiple versions of a defaulted special member functions are not allowed" is bogus and ungrammatical"
utilities\tuple\tuple.tuple\tuple.cnstr\test_lazy_sfinae.pass.cpp

# Compiler bug: DevCom-409222 "Constructing rvalue reference from non-reference-related lvalue reference"
utilities\meta\meta.unary\meta.unary.prop\is_constructible.pass.cpp

Expand Down