Skip to content

Replace __pragma with _Pragma #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 3 commits into from
May 21, 2021
Merged

Replace __pragma with _Pragma #1342

StephanTLavavej merged 3 commits into from
May 21, 2021

Conversation

@CdTCzech
Copy link
Contributor

@CdTCzech CdTCzech commented Oct 5, 2020

This change was already merged as #662, but later reverted in #675.
Resolves #659

@CdTCzech
Replace __pragma with _Pragma
4adceda 
This change was already merged as microsoft#662, but later reverted in microsoft#675.
Resolves microsoft#659
@CdTCzech CdTCzech requested a review from a team as a code owner October 5, 2020 12:35
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 6, 2020
@sylveon

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej added the help wanted Extra attention is needed label Oct 8, 2020
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej added blocked Something is preventing work on this and removed help wanted Extra attention is needed labels Oct 18, 2020
@StephanTLavavej

This comment has been minimized.

Sign in to view
Base automatically changed from master to main January 28, 2021 00:35
@StephanTLavavej StephanTLavavej added blocked on 16.10p2 and removed blocked Something is preventing work on this labels Feb 27, 2021
@StephanTLavavej

This comment has been minimized.

Sign in to view
@fsb4000

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej
Copy link
Member

StephanTLavavej commented May 15, 2021

Internally reported VSO-1329304 "EDG doesn't understand Standard _Pragma".

@StephanTLavavej StephanTLavavej self-assigned this May 20, 2021
@StephanTLavavej StephanTLavavej merged commit 5fd5fe5 into microsoft:main May 21, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented May 21, 2021

Thanks for this long-awaited code cleanup! 📅 🎉 😹 The EDG IntelliSense maintainers have enabled support for _Pragma although we'll need to wait for that to ship in VS before attempting to use it.

@StephanTLavavej StephanTLavavej mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Use Standard _Pragma

5 participants

@CdTCzech @StephanTLavavej @sylveon @fsb4000 @CaseyCarter