-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Replace __pragma with _Pragma #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
VS 2019 16.6 Preview 2 now supports Standard _Pragma.
|
From the comment in the issue:
|
Oh, such a mistake :( I was so scared of my first pull request ever that I forgot to sync my changes properly... |
No need to be scared: we save our soul-crushing toxicity for the second pull request. (Don't worry about the test failures; |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thank you for the contribution! |
Replace __pragma with _Pragma (microsoft#662)
This reverts commit 42d5df0. Reverting due to a bug in how /Zc:preprocessor handles _Pragma see VSO-1091758 for more details
|
Unfortunately we had to revert this PR due to issues with _Pragma in 16.6 preview 2 under /Zc:preprocessor. :( We'll revert the PR once that issue is fixed |
This reverts commit 42d5df0. Reverting due to a bug in how /Zc:preprocessor handles _Pragma see VSO-1091758 for more details Co-authored-by: Charles <barto.charlie+code@gmail.com>
I'm always glad to be a first revert of the repository 😄 |
|
Not a problem with your work at all! 😸 In fact, your change has led to two concrete improvements: (1) we've updated our checklist for merging PRs, and (2) we were completely lacking STL test coverage for |
This change was already merged as microsoft#662, but later reverted in microsoft#675. Resolves microsoft#659
Description
Resolves #659
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.