Add testing instructions to the README #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Mar 27, 2020
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Looks great!
I am thrilled to test it out over the weekend.
StephanTLavavej
requested changes
Mar 27, 2020
CaseyCarter
suggested changes
Mar 27, 2020
cbezault
force-pushed
the
test-update-readme
branch
2 times, most recently
from
c705760 to
240fd59
Compare
4 tasks
Member
|
#645 should fix the antivirus false positive |
CaseyCarter
approved these changes
Mar 29, 2020
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net> Co-Authored-By: Casey Carter <cartec69@gmail.com>
cbezault
force-pushed
the
test-update-readme
branch
from
240fd59 to
38b701b
Compare
Contributor
Author
|
Sorry I force-pushed, something weird was going on. |
CaseyCarter
reviewed
Mar 30, 2020
CaseyCarter
approved these changes
Mar 30, 2020
Co-Authored-By: Casey Carter <cartec69@gmail.com>
StephanTLavavej
requested changes
Mar 31, 2020
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
SuperWig
reviewed
Mar 31, 2020
CaseyCarter
approved these changes
Mar 31, 2020
4 tasks
StephanTLavavej
requested changes
Mar 31, 2020
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
miscco
reviewed
Mar 31, 2020
|
|
||
| The `XPASS` and `XFAIL` result codes are less obvious. `XPASS` is actually a failure result and indicates that we | ||
| expected a test to fail but it passed. `XFAIL` is a successful result and indicates that we expected the test to fail | ||
| and it did. Typically an `XPASS` result means that the `expected_results.txt` file for the testsuite needs to be |
Contributor
There was a problem hiding this comment.
I gues you want a negation here and it did *not*
Contributor
Author
There was a problem hiding this comment.
No I think what is written is correct. XFAIL means that we expected the test to fail and it did. XPASS means we expected the test to fail but it passed.
I know, it's a little confusing.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add instructions for running the tests by hand to the README.
Also fix/skip some flaky tests so I can get a green checkmark.